need to be able to unload bzr-git

Bug #526133 reported by Michael Hudson-Doyle on 2010-02-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Git Plugin
Wishlist
Robert Collins

Bug Description

In the launchpad tests, we expect bzr-git and the other foreign branch plugins to not be loaded, but a few tests have to load them. It would be easier for us if we could unload bzr-git at the end of the test, rather than have to play tricks with layers.

Related branches

On 23 February 2010 11:13, Michael Hudson <email address hidden> wrote:
> Public bug reported:
>
> In the launchpad tests, we expect bzr-git and the other foreign branch
> plugins to not be loaded, but a few tests have to load them.  It would
> be easier for us if we could unload bzr-git at the end of the test,
> rather than have to play tricks with layers.

bzr itself doesn't really have a concept of unloading a plugin,
because they can and sometimes do do arbitrary monkeypatching, and
that's not easy to reverse. We could add something, either
specifically for bzr-git or generally, but will your tests really be
reliable?

--
Martin <http://launchpad.net/~mbp/>

Robert Collins (lifeless) wrote :

this is a workaround for deeper issues inside the lp codebase itself; but one that is low risk, easily identified and will add breathing room to the the lp test suite.

Changed in bzr-git:
status: New → Confirmed
importance: Undecided → Wishlist
assignee: nobody → Robert Collins (lifeless)
Jelmer Vernooij (jelmer) wrote :

On Tue, 2010-02-23 at 00:13 +0000, Michael Hudson wrote:
> In the launchpad tests, we expect bzr-git and the other foreign branch
> plugins to not be loaded, but a few tests have to load them. It would
> be easier for us if we could unload bzr-git at the end of the test,
> rather than have to play tricks with layers.
What is the problem with having bzr-git loaded exactly? Are some tests
failing if bzr-git is loaded? If so, couldn't we just fix those tests?

Cheers,

Jelmer

Michael Hudson-Doyle (mwhudson) wrote :

This conversation between myself and Rob has lots of gory details: http://pastebin.ubuntu.com/381958/

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Hudson wrote:
> This conversation between myself and Rob has lots of gory details:
> http://pastebin.ubuntu.com/381958/
>

Note that whatever changed with codehosting, it also broke "bzr cat
lp:~bzr-pqm/bzr/bzr.dev/bzr"

Specifically, this form is now trying to probe for a branch at
~bzr-pqm/bzr/bzr.dev/bzr/.bzr/branch-format and is getting a
PermissionDenied error, rather than NoSuchFile.

If we got NoSuchFile then we would probe up a directory, and find that
everything is ok.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuEJMcACgkQJdeBCYSNAAM9kACgl1KcQFPLzEGnOaUi+ekunPll
lcEAn2MnJcI8rIqSfEj6DtphG90P7io/
=H+8L
-----END PGP SIGNATURE-----

Michael Hudson-Doyle (mwhudson) wrote :

John A Meinel wrote:
> Michael Hudson wrote:
>> This conversation between myself and Rob has lots of gory details:
>> http://pastebin.ubuntu.com/381958/
>
>
> Note that whatever changed with codehosting, it also broke "bzr cat
> lp:~bzr-pqm/bzr/bzr.dev/bzr"

Nothing has changed here for at least two years.

> Specifically, this form is now trying to probe for a branch at
> ~bzr-pqm/bzr/bzr.dev/bzr/.bzr/branch-format and is getting a
> PermissionDenied error, rather than NoSuchFile.
>
> If we got NoSuchFile then we would probe up a directory, and find that
> everything is ok.

Yeah. Feel free to do the 'me too' thing on
https://bugs.edge.launchpad.net/launchpad-code/+bug/526131 :-)

Cheers,
mwh

Jelmer Vernooij (jelmer) on 2010-03-23
Changed in bzr-git:
status: Confirmed → Fix Committed
Jelmer Vernooij (jelmer) on 2010-06-03
Changed in bzr-git:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers