git: insert SSHVendor into dulwich rather than relying on ssh.exe

[Alexander Belchenko]

I have bzr copy of git repo. Committed small change. Trying to push to github via bzr:

C:\work\Documents\GitHub\test.bzr>bzr -Derror dpush <email address hidden>:bialix/test.git
bzr: ERROR: exceptions.WindowsError: [Error 2] The system cannot find the file specified

Traceback (most recent call last):
  File "bzrlib\commands.pyo", line 920, in exception_to_return_code
  File "bzrlib\commands.pyo", line 1131, in run_bzr
  File "bzrlib\commands.pyo", line 673, in run_argv_aliases
  File "bzrlib\commands.pyo", line 695, in run
  File "bzrlib\cleanup.pyo", line 136, in run_simple
  File "bzrlib\cleanup.pyo", line 166, in _do_with_cleanups
  File "bzrlib\foreign.pyo", line 319, in run
  File "bzrlib\branch.pyo", line 1142, in push
  File "C:/Program Files/Bazaar/plugins\git\branch.py", line 1147, in push
  File "C:/Program Files/Bazaar/plugins\git\push.py", line 352, in fetch_refs
  File "C:/Program Files/Bazaar/plugins\git\remote.py", line 427, in send_pack
  File "C:/Program Files/Bazaar/plugins\git\remote.py", line 247, in send_pack
  File "dulwich\client.pyo", line 439, in send_pack
  File "dulwich\client.pyo", line 627, in _connect
  File "dulwich\client.pyo", line 605, in connect_ssh
  File "subprocess.pyo", line 623, in __init__
  File "subprocess.pyo", line 833, in _execute_child
WindowsError: [Error 2] The system cannot find the file specified

[Alexander Belchenko (bialix)]

Local dpush works fine.

[Martin Packman (gz)]

Problem seems to basically be that dulwich copies a little bit of the bzrlib SSHVendor code rather than depending on bzr, so drops all the logic needed to work with ssh apart from forking out to OpenSSH compatible tools.

[Alexander Belchenko (bialix)]

What tool does it need? ssh.exe? only?

[Jelmer Vernooij (jelmer)]

ssh.exe should be sufficient

[Martin Packman (gz)]

Swapping in the bzrlib SSHVendor implementation is slightly harder than it looks. Not only does the connect_ssh have a different signature, but the way the ssh subprocess gets wrapped is different, and it would be another step further to get paramiko working. Maybe fixing it in dulwich makes more sense after all.

[Jelmer Vernooij (jelmer)]

Dulwich doesn't know about bzr-git. I don't think it should know about bzr's SSHVendor.