fast-import fails on invalid timezones

Bug #959154 reported by Mark Grandi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-fastimport
Fix Released
Low
Jelmer Vernooij

Bug Description

I was trying to fast import the rubyonrails git repostory into bzr, when i got this error:

bzr: ERROR: 36508955: Parse error: line 36508955: Timezone '+051800' could not be converted.

this is the command that i ran:

git clone git://github.com/rails/rails.git
git fast-export --all --progress=1000 --signed-tags=strip > rails.fe

cd ..
bzr init-repo rails_bzr_repo
bzr fast-import rails/rails.fe rails_bzr_repo

it seems that the commit in question is this:

commit 4cf94979c9f4d6683c9338d694d5eb3106a4e734
Author: Vijay Dev <email address hidden>
Date: Mon Aug 29 06:50:23 2011 +51800

    edit changelog to mention about x_sendfile_header default change

(on github: https://github.com/rails/rails/commit/4cf94979c9f4d6683c9338d694d5eb3106a4e734)

its weird that Github is able to get a date out of it, and that git seems fine with having an invalid timezone, but nevertheless , someone on irc said it should just try to parse the timezone, and if that fails, default to UTC rather then failing the entire import.

Jelmer Vernooij (jelmer)
Changed in bzr-fastimport:
status: New → Triaged
importance: Undecided → Low
Changed in python-fastimport:
status: New → Triaged
importance: Undecided → Low
Jelmer Vernooij (jelmer)
Changed in python-fastimport:
status: Triaged → Fix Committed
assignee: nobody → Jelmer Vernooij (jelmer)
no longer affects: bzr-fastimport
Jelmer Vernooij (jelmer)
Changed in python-fastimport:
status: Fix Committed → Fix Released
milestone: none → 0.9.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.