KeyError: 20

[Saša Janiška]

Hi!

Running: x2d -f git be (be is http://gitorious.org/be/be) gives:

Traceback (most recent call last):
  File "/home/gour/.bazaar/plugins/fastimport/exporters/darcs/darcs-fast-import", line 318, in <module>
    h.handle()
  File "/home/gour/.bazaar/plugins/fastimport/exporters/darcs/darcs-fast-import", line 300, in handle
    self.handle_commit()
  File "/home/gour/.bazaar/plugins/fastimport/exporters/darcs/darcs-fast-import", line 208, in handle_commit
    sock.write(self.marks[idx])
KeyError: 20

Sincerely,
Gour

[Miklos Vajna (vmiklos)]

http://vmiklos.hu/gitweb/?p=bzr-fastimport.git;a=patch;h=7cc1706ec96298b4808e299f2560fb14095034f5

This should fix the reported issue.

Now it fails later with:

Traceback (most recent call last):
  File "/home/vmiklos/bin/darcs-fast-import", line 317, in <module>
    h.handle()
  File "/home/vmiklos/bin/darcs-fast-import", line 299, in handle
    self.handle_commit()
  File "/home/vmiklos/bin/darcs-fast-import", line 205, in handle_commit
    sock = open(path, "w")
IOError: [Errno 21] Is a directory: 'interfaces/email/interactive/becommands'

I don't have a patch for that issue yet. (But it's on my TODO.)

[Miklos Vajna (vmiklos)]

OK, I now see, it's because a directory is replaced by a symlink. Now I can add a better error message, but what should I do with symlinks? Darcs does not support them. :/

[Miklos Vajna (vmiklos)]

Usable error message for symlinks is implemented here:

http://vmiklos.hu/gitweb/?p=bzr-fastimport.git;a=commitdiff;h=41e9e75d6166e44f73ee1f6570690969c35ddae4

[Miklos Vajna (vmiklos)]

I worked a bit more on this, now it imports here fine.

Please test the code from git://vmiklos.hu/bzr-fastimport, using x2d -f git --symhack <repo>.

If it looks fine at you as well, then I'll push it to a bzr branch and propose for merging.

Thanks.

[Saša Janiška (gour)]

Thanks a lot for the fix.

It works here!

Sincerely,
Gour