Env. variable language takes precedence over Bazaar configuration

Bug #948268 reported by Dedeco on 2012-03-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Explorer
Medium
Dedeco

Bug Description

If user changes the language in Preferences it won't be changed because enviroment variable overrides it.

How to reproduce:

- have LANGUAGE enviroment variable (or system's locale for win32) set to something

- open bzr-explorer and change preferences to some other language (you get a dialog box saying to restart bzr-explorer)

- close bzr-explorer and open again. The language is still the enviroment language.

I am sending a patch that I have tested locally.

Related branches

Dedeco (dedeco) wrote :
Alexander Belchenko (bialix) wrote :

What do you mean by "system's locale for win32"?

Alexander Belchenko (bialix) wrote :

Put your patch into your branch and push your branch to launchpad. then open this branch, e.g. with `bzr lp-open` command and propose it for merging. This is how we work.

Changed in bzr-explorer:
status: New → Confirmed
importance: Undecided → Medium

> What do you mean by "system's locale for win32"?
Thanks for pointing it. Now I found this part a little odd.

I do not use Windows, I didn't do tests on it. But if the enviroment
variable isn't set, the program won't execute the same code that I have
tested and results may be different.

I guess the Windows user must change "Language settings" (or something
like this) on Control Panel.

Alexander Belchenko (bialix) wrote :

Dedeco пишет:
>> What do you mean by "system's locale for win32"?
> Thanks for pointing it. Now I found this part a little odd.
>
> I do not use Windows, I didn't do tests on it. But if the enviroment
> variable isn't set, the program won't execute the same code that I have
> tested and results may be different.

I'm working on Windows. That code is correct.

Gordon Tyler (doxxx) wrote :

I thought the convention was that environment variables always override an application's configuration?

Dedeco (dedeco) wrote :

Gordon Tyler:
> environment variables always override an application's configuration
Well, I wouldn't say so. I would agree if you say "an application's
default". So programs would /prefer/ the language that the system is
using (but without the need to restrict to this language).

I use my system configured to my local language. And I use some programs
that have multi-language support. I expect them to use my local language
if they have a translation for it. Or else, they might use their default
(usually english).

But, if I manually change the program's language configuration I must
expect that it disobeys the enviroment variable from there on, or else
is pointless that it has a "language configuration". Don't you agree
with this?

Few programs that I use that work like this: Open Office, Thunderbird,
Opera.

Or I would only have one "big" system wide configuration (without more
efforts).

Dedeco (dedeco) on 2012-03-12
Changed in bzr-explorer:
status: Confirmed → In Progress
Changed in bzr-explorer:
milestone: none → 1.3.0
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers