InvalidURL opening branch with non-ascii characters from repository view
Bug #777860 reported by
Jelmer Vernooij
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar Explorer |
Fix Released
|
High
|
Martin Packman |
Bug Description
I'm using Bazaar Explorer 1.1.2 with bzr 2.3.1 on Windows 7 Prof. 32 Bit.
Here we have a virtual repository with 99 real repositories inside:
http://
If i double click on a directory with special characters like ä, ö, ü, ß or µ, I get such error messages:
http://
http://
But if I open the directory directly without opening the virtual repository first, there are no problems. I can open the branch and commit changes without any issues.
So what can be done to fix this error?
Related branches
lp:~gz/bzr-explorer/repo_view_non_ascii_branch_open_777860
- Alexander Belchenko: Approve
-
Diff: 28 lines (+6/-1)2 files modifiedNEWS (+5/-0)
lib/view_repository.py (+1/-1)
tags: | added: unicode |
summary: |
- error accessing special character files on Windows + InvalidURL opening branch with non-ascii characters from repository view |
Changed in bzr-explorer: | |
status: | Confirmed → In Progress |
assignee: | nobody → Martin [gz] (gz) |
Changed in bzr-explorer: | |
milestone: | none → 1.1.3 |
status: | In Progress → Fix Released |
importance: | Medium → High |
To post a comment you must log in.
I can reproduce this with trunk qbzr and explorer. Setting BZR_PDB lets you see a traceback along the lines of:
...\bzrlib\ plugins\ explorer\ lib\commands. py(164) run() plugins\ explorer\ lib\view_ repository. py(247) do_double_ clicked( ) open_location( ) plugins\ explorer\ lib\view_ repository. py(189) do_open_ location( ) abspath( self._relpath) plugins\ explorer\ lib\view_ repository. py(243) _get_abspath( ) root_transport( ).abspath( relpath) transport\ local.py( 110)abspath( ) normpath( osutils. pathjoin( urlutils. py(536) unescape( ) InvalidURL( url, 'URL was not a plain ASCII url: %s' % (e,))
-> app.exec_()
...\bzrlib\
-> self.do_
...\bzrlib\
-> abspath = self._get_
...\bzrlib\
-> return self._get_
...\bzrlib\
-> path = osutils.
> ...\bzrlib\
-> raise errors.
So it seems bzr-explorer is violating a bzrlib expectation about how urls should be formed. I think there must be a bug in the qbzr error handling as well as the traceback doesn't end up in .bzr.log for some reason.