Nested folders in toolbars.xml prevent startup

Reported by Simon Kersey on 2010-04-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Explorer
Medium
Simon Kersey

Bug Description

WinXP, Latest Explorer (1.1.0dev)

If toolbars.xml contains the following:

<folder title="Toolbars">
  <folder title="kind:branch">
    <folder title="fred" icon="actions/bookmark-new">
      <tool action="ls" icon="actions/bookmark-new" title="aaa" type="bzr" />
    </folder>
  </folder>
</folder>

Then Explorer will not start.

.bzr.log contains the following:

Fri 2010-04-16 17:16:56 +0100
0.131 bazaar version: 2.1.0rc1
0.131 bzr arguments: [u'explorer']
0.151 looking for plugins in C:\SJK\BazaarPluginDev\bzr-reserved-edit
0.211 looking for plugins in C:/Program Files/Bazaar/plugins
0.291 encoding stdout as sys.stdout encoding 'cp850'
0.772 loading explorer extensions for clothes [u'Bazaar support', u'Register on Launchpad']
0.772 explorer extensions provided by the fastimport plugin in C:/Program Files/Bazaar/plugins/fastimport/explorer
0.772 explorer extensions provided by the trunk plugin in C:/SJK/BazaarPluginDev/bzr-reserved-edit/trunk/explorer
0.812 Traceback (most recent call last):
  File "bzrlib\commands.pyo", line 853, in exception_to_return_code
  File "bzrlib\commands.pyo", line 1055, in run_bzr
  File "bzrlib\commands.pyo", line 661, in run_argv_aliases
  File "bzrlib\commands.pyo", line 665, in run_direct
  File "bzrlib\cleanup.pyo", line 122, in run_simple
  File "bzrlib\cleanup.pyo", line 156, in _do_with_cleanups
  File "C:/Program Files/Bazaar/plugins\explorer\lib\commands.py", line 154, in run
  File "C:/Program Files/Bazaar/plugins\explorer\lib\explorer.py", line 177, in __init__
  File "C:/Program Files/Bazaar/plugins\explorer\lib\builders\toolset_builders.py", line 87, in __init__
  File "C:/Program Files/Bazaar/plugins\explorer\lib\builders\toolset_builders.py", line 119, in _load
  File "C:/Program Files/Bazaar/plugins\explorer\lib\builders\toolset_builders.py", line 132, in _build_toolbars
  File "C:/Program Files/Bazaar/plugins\explorer\lib\builders\toolset_builders.py", line 182, in _add_tool_entry
TypeError: _add_tool_entry() takes exactly 5 arguments (4 given)

Changed in bzr-explorer:
status: New → Fix Released
milestone: none → 1.1
importance: Undecided → Medium
assignee: nobody → Simon Kersey (simon-kersey)
Changed in bzr-explorer:
milestone: 1.1 → 1.1beta1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers