explorer selftests should make pyqt4 a soft dependency
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar Explorer |
Fix Released
|
High
|
Alexander Belchenko |
Bug Description
If the explorer plugin is present but pyqt4 is not installed, you can't run the bzr test suite at all, because explorer has an unguarded import statement. I think there is a mechanism by which it can turn this into just skipping the tests?
2.694 Traceback (most recent call last):
File "/usr/lib/
return the_callable(*args, **kwargs)
File "/usr/lib/
ret = run(*run_argv)
File "/usr/lib/
return self.run(
File "/usr/lib/
result = selftest(
File "/usr/lib/
suite = test_suite(
File "/usr/lib/
plugin_suite = plugin.
File "/usr/lib/
return loader.
File "/usr/lib/
return load_tests(
File "/home/
return load_tests(
File "/home/
suite.
File "/usr/lib/
result.
File "/usr/lib/
module = _load_module_
File "/usr/lib/
module = __import_
File "/home/
from PyQt4 import QtCore, QtGui
ImportError: No module named PyQt4
Related branches
- Ian Clatworthy: Approve
-
Diff: 39 lines (+12/-1)2 files modifiedNEWS (+2/-0)
tests/__init__.py (+10/-1)
Changed in bzr-explorer: | |
assignee: | John A Meinel (jameinel) → Alexander Belchenko (bialix) |
status: | Confirmed → Fix Committed |
Changed in bzr-explorer: | |
status: | Fix Committed → Fix Released |
milestone: | none → 1.0.0rc1 |
We have similar guard code in qbzr for the same reasons. Just need to copy-paste the approach, perhaps.