Working tree browser is slow to open

Bug #464581 reported by Martin Packman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Explorer
Fix Released
Low
Martin Packman

Bug Description

In common with other programs using alien toolkits under windows, bazaar explorer likes checking my floppy drive when it doesn't need to. This adds at least a second to the startup time of `bzr explorer somebranch` and is generally annoying.

Related branches

Revision history for this message
Martin Packman (gz) wrote :

Profile of current trunk, created by doing `bzr explorer bzr-explorer` and hitting alt+f4 as soon as the window came up. Note lines:

        1 0.014 0.014 4.521 4.521 location.py:403(add_location)
        3 0.013 0.004 4.097 1.366 explorer.py:487(changed_view)
        2 4.078 2.039 4.080 2.040 wt_browser.py:205(set_root)

Revision history for this message
Martin Packman (gz) wrote :

Profile of attached branch using the same method, note absence of three lines from before and reduced overall runtime.

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 464581] [NEW] Working tree browser is slow to open

Martin пишет:
> In common with other programs using alien toolkits under windows, bazaar
> explorer likes checking my floppy drive when it doesn't need to. This
> adds at least a second to the startup time of `bzr explorer somebranch`
> and is generally annoying.

I'm observing this too. I'm really think it's related to Qt toolkit.

Also I want to note that I saw the same behavior with standard Windows dialog "Select directory".

I'm not sure how we can workaround this fact.

Revision history for this message
Martin Packman (gz) wrote :

On 30/10/2009, Alexander Belchenko <email address hidden> wrote:
>
> Also I want to note that I saw the same behavior with standard Windows
> dialog "Select directory".
>
> I'm not sure how we can workaround this fact.

Yeah, I think we're stuffed on "Browse for Folder", the (few) other
windows applications that use it also have the pause.

The working tree pane seems fixable though, see the linked branch.

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

Martin,

I've applied the patch in the linked branch. I'll let you decide whether to leave the broader bug open or not.

Changed in bzr-explorer:
importance: Undecided → Low
milestone: none → 0.9.0
status: New → Fix Committed
Revision history for this message
Martin Packman (gz) wrote : Re: [Bug 464581] Re: Working tree browser is slow to open

On 31/10/2009, Ian Clatworthy <email address hidden> wrote:
> Martin,
>
> I've applied the patch in the linked branch. I'll let you decide whether
> to leave the broader bug open or not.

Thanks Ian. Closing this bug is fine, can open another one if
inspiration strikes elsewhere.

Changed in bzr-explorer:
status: Fix Committed → Fix Released
Changed in bzr-explorer:
assignee: nobody → Martin (gzlist)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.