click on changed image filename -> open image in text editor

[Alexander Belchenko]

If I click on image file in status view or in working tree view then bzr-explorer trying to open it in configured text editor. This is wrong.

Explorer should use either system default image editor or have ability to configure it.

Ditto for other non-plain text files, e.g. OpenOffice document files.

[Ian Clatworthy (ian-clatworthy)]

Alexander Belchenko wrote:
> Public bug reported:
>
> If I click on image file in status view or in working tree view then
> bzr-explorer trying to open it in configured text editor. This is wrong.

The status view is an explicit edit operation. Double-clicking in the
working tree ought to launch whatever application is registered as
"open" on your OS for that file type.

I don't want to register dozens of 'editors' in explorer's
configuration. I can see a case for doing a small number though, e.g.
for images, web pages and office documents.

Ian C.

[Alexander Belchenko (bialix)]

Ian Clatworthy пишет:
> Alexander Belchenko wrote:
>> Public bug reported:
>>
>> If I click on image file in status view or in working tree view then
>> bzr-explorer trying to open it in configured text editor. This is wrong.
>
> The status view is an explicit edit operation. Double-clicking in the
> working tree ought to launch whatever application is registered as
> "open" on your OS for that file type.
>
> I don't want to register dozens of 'editors' in explorer's
> configuration. I can see a case for doing a small number though, e.g.
> for images, web pages and office documents.

You can't avoid this fine-grained configuration forever.
As I wrote there is possible to use system-default tools for non-text files.

>
> Ian C.
>

[Ian Clatworthy (ian-clatworthy)]

I can't see any APIs in PyQt for getting the 'editor' for a file, just the app to open it. So ...

I'm thinking of adding a configuration file mapping mime-types to editor apps. That sounds more robust than just relying on file extensions. I need to chase down how to find the 'mime-type' of a file via PyQt to progress this. Or maybe mime-type is overkill and using extensions is fine?

[Ian Clatworthy (ian-clatworthy)]

Custom editor support is available in rev 305