AttributeError: 'NoneType' object has no attribute 'canonicalFilePath'

[Mitsuhiro Koga]

bzr-explorer: revno171
bzr: 1.16.1

To reproduce:
1) Open a branch with bazaar-explorer.
2) Push edit button without selecting any file.

or
1) Open two branch with bazaar-explorer.
2) Select a file in WT.
3) Switch another branch.
4) Push edit button without selecting any file.

Traceback (most recent call last):
  File "/Users/shiena/.bazaar/plugins/explorer/lib/wt_browser.py", line 123, in do_edit_file
    path = fileinfo.canonicalFilePath()
AttributeError: 'NoneType' object has no attribute 'canonicalFilePath'

[Mitsuhiro Koga (shiena-jp)]

I think that you should invalidate the edit button, when the item has not been selected.
And, after the branch is switched, the selection has been released.

=== modified file lib/wt_browser.py
--- lib/wt_browser.py 2009-07-16 12:31:36 +0000
+++ lib/wt_browser.py 2009-07-18 09:56:41 +0000
@@ -152,9 +152,13 @@
             self.stacked.setCurrentIndex(1)
             index = self.model.index(path)
             self.view.setRootIndex(index)
+ self.view.selectionModel().reset()
         self._root = path
         self._selected_fileinfo = None
+ self._edit_button.setEnabled(False)

[Mitsuhiro Koga (shiena-jp)]

Sorry, indent shifted. The patch is appended.

[Ian Clatworthy (ian-clatworthy)]

Thanks for the patch. Applied in rev 172.