Manage button does not work in path name for which URL encode is necessary.

Bug #396695 reported by Mitsuhiro Koga
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Explorer
Fix Released
Undecided
Unassigned

Bug Description

Platform:
OS : Windows XP
bzr : 1.16.1
bzr-explorer : revno.161

Step to reproduce:
1) Create a new folder. For instance, including the blank.
2) Create a new branch in it.
3) Browse it with bazaar-explorer.
4) Push the Manage button.

How to fix:
Replace "QUrl()" that uses the local file with "QUrl.fromLocalFile()".

=== modified file lib/explorer.py
--- lib/explorer.py 2009-07-07 17:53:03 +0000
+++ lib/explorer.py 2009-07-07 17:53:36 +0000
@@ -835,7 +835,7 @@
             msg = u'Open: %s' % (path,)
             self.show_note("Diagnostic Mode", msg)
             return
- QtGui.QDesktopServices.openUrl(QtCore.QUrl(path))
+ QtGui.QDesktopServices.openUrl(QtCore.QUrl.fromLocalFile(path))

     def _do_view_action(self, action, target):
         """Do an action on a target.

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

Thanks for the bug report and patch. Applied in rev 163.

Changed in bzr-explorer:
status: New → Fix Released
Changed in bzr-explorer:
milestone: none → 0.5
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.