win32 installer fails to launch bzr-explorer on completion

[Irongut]

Using the bzr-explorer-setup-0.3.1.exe installer, when it completes I leave the Launch Bazaar Explorer checkbox ticked.

Bazaar Explorer doesn't run and an error dialog is displayed:

Unable to execute file:
bzr
CreateProcess failed; code 267.
The directory name is invalid.

I have no problems with bzr, which is in my path. When I click the Bazaar Explorer icon it works.

Win2k, bzr 1.16, qbzr 0.11, bzr-explorer 0.3.1

[Alexander Belchenko (bialix)]

Irongut пишет:
> Public bug reported:
>
> Using the bzr-explorer-setup-0.3.1.exe installer, when it completes I
> leave the Launch Bazaar Explorer checkbox ticked.
>
> Bazaar Explorer doesn't run and an error dialog is displayed:
>
> Unable to execute file:
> bzr
> CreateProcess failed; code 267.
> The directory name is invalid.

I don't know what this error actually means in your case.
Perhaps it somehow related to the current directory from which installer
have been launched.

Maybe it's related to the fact you're working as limited user, but you
ran installer as admin.

I can't reproduce this effect on my machine with Win2k.

> I have no problems with bzr, which is in my path. When I click the
> Bazaar Explorer icon it works.
>
> Win2k, bzr 1.16, qbzr 0.11, bzr-explorer 0.3.1

[Alexander Belchenko (bialix)]

I don't know what this error actually means in your case.
Perhaps it somehow related to the current directory from which installer have been launched.

Maybe it's related to the fact you're working as limited user, but you ran installer as admin.

I can't reproduce this effect on my machine with Win2k.

[Irongut (irongut)]

> I don't know what this error actually means in your case.
> Perhaps it somehow related to the current directory from which installer have been launched.

Are there any assumptions about paths made in the code that launches bzr-explorer at the end of install? My system is unconventional with F: as my system drive, no C: drive and CD/DVD drives in D: and E:.

> Maybe it's related to the fact you're working as limited user, but you ran installer as admin.

My account has local admin rights so the installer was run as admin and I run bzr, bzr-explorer, etc as admin too.

> I can't reproduce this effect on my machine with Win2k.

If I uninstall and re-install I can reproduce it every time.

[Alexander Belchenko (bialix)]

Irongut пишет:
>> I don't know what this error actually means in your case.
>> Perhaps it somehow related to the current directory from which installer have been launched.
>
> Are there any assumptions about paths made in the code that launches
> bzr-explorer at the end of install? My system is unconventional with F:
> as my system drive, no C: drive and CD/DVD drives in D: and E:.

For building installer I'm using Inno Setup utility:
http://www.innosetup.com/isinfo.php

Launching application in the end of installation process basically doing
it this way: installer try to launch application named "bzr" with one
argument "explorer". I.e. it's mostly what user can use in the
command-line or using Start -> Run menu.

Perhaps there is some hardcoded dependencies on existence of C drive in
the system, or the fact that Windows itself should be located on C
drive. I don't know is it true, because it's inside Inno Setup itself.

Quick check in Inno Setup FAQ and knowledge base did not reveal anything
similar to your problem.

>> I can't reproduce this effect on my machine with Win2k.
>
> If I uninstall and re-install I can reproduce it every time.

I can't reproduce and therefore have no idea have to fix it.

If you want to try to fix it yourself then I can provide simple
instructions how to build installer. It's easy enough, you only need
Inno Setup tool installed on your machine.

[Ian Clatworthy (ian-clatworthy)]

Alexander Belchenko wrote:
> Launching application in the end of installation process basically doing
> it this way: installer try to launch application named "bzr" with one
> argument "explorer". I.e. it's mostly what user can use in the
> command-line or using Start -> Run menu.
>
> Perhaps there is some hardcoded dependencies on existence of C drive in
> the system, or the fact that Windows itself should be located on C
> drive. I don't know is it true, because it's inside Inno Setup itself.
>
I experienced problems in the past building installers on Windows where
the PATH wasn't updated in time for the "Launch now" to work. Maybe try
the full path to the executable if Inno lets you?

Ian C.

[Alexander Belchenko (bialix)]

Ian Clatworthy пишет:
> Alexander Belchenko wrote:
>> Launching application in the end of installation process basically doing
>> it this way: installer try to launch application named "bzr" with one
>> argument "explorer". I.e. it's mostly what user can use in the
>> command-line or using Start -> Run menu.
>>
>> Perhaps there is some hardcoded dependencies on existence of C drive in
>> the system, or the fact that Windows itself should be located on C
>> drive. I don't know is it true, because it's inside Inno Setup itself.
>>
> I experienced problems in the past building installers on Windows where
> the PATH wasn't updated in time for the "Launch now" to work. Maybe try
> the full path to the executable if Inno lets you?

We don't know the full path for executable.

I'm trying to create universal installer suitable for both standalone bzr.exe and for python-based
bzr installation. That's why I don't try to found actual bzr executable file.

I'm thinking about problem with launching bzr explore on your computer from installer,
and I think it's worth trying to slightly change command-line, e.g.

cmd /c bzr explorer

May be this helps. But this idea have to be tested on the computer where the problem can be reproduced.

[Irongut (irongut)]

I have a solution that works on my system, remove the WorkingDir parameter from the run command. So the Run section becomes:

[Run]
Filename: "bzr"; Parameters: "explorer"; Description: "{cm:LaunchProgram,Bazaar Explorer}"; Flags: nowait postinstall skipifsilent

[Alexander Belchenko (bialix)]

Irongut пишет:
> I have a solution that works on my system, remove the WorkingDir
> parameter from the run command. So the Run section becomes:

OK, I understand the problem. Inno has special constant for system drive ({sd}).
What if we using this constant in WorkingDir?

Can you check following variant:

[Run]
Filename: "bzr"; Parameters: "explorer"; WorkingDir: {sd}\; Description: "{cm:LaunchProgram,Bazaar
Explorer}"; Flags: nowait postinstall skipifsilent

[Irongut (irongut)]

> OK, I understand the problem. Inno has special constant for system drive ({sd}).
> What if we using this constant in WorkingDir?

Yes that also works.

The WorkingDir param should also be changed like that for the entries in the Icons section. The icons were working before but it can't be good specifying a drive that doesn't exist for the working dir. I've done that in the attached iss file.

[Alexander Belchenko (bialix)]

Irongut пишет:
>> OK, I understand the problem. Inno has special constant for system drive ({sd}).
>> What if we using this constant in WorkingDir?
>
> Yes that also works.
>
> The WorkingDir param should also be changed like that for the entries in
> the Icons section. The icons were working before but it can't be good
> specifying a drive that doesn't exist for the working dir. I've done
> that in the attached iss file.

Yes, of course, this should be made for all icons.
Thanks for the help!

[Tymek (maju7)]

Hi I have the same problem in 0.8

I'm running Vista Professional.

I can run "bzr explorer" from the Windows "Run..." window. Having said that this ("bzr explorer") starts a cmd and then explorer.

I won't be trying to fix this so please let me know if need any more information about my configuration etc.

I have TortoiseSVN installed.

My PATH:
C:\Perl\site\bin;C:\Perl\bin;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\System32\Wbem;C:\Program Files\ATI Technologies\ATI.ACE\Core-Static;C:\Program Files\Common Files\Roxio Shared\DLLShared\;C:\Program Files\Common Files\Roxio Shared\9.0\DLLShared\;C:\Program Files\TortoiseSVN\bin;C:\Program Files\QuickTime\QTSystem\;C:\Program Files\Bazaar

Thanks
Tymek

[Lucius (luciusf)]

Same on Win7 64bit. Appears to be path problem. Error 2 = ERROR_FILE_NOT_FOUND

[Alexander Belchenko (bialix)]

Now explorer bundled into official standalone installer for bzr itself. We don't plan to devote efforts to this (really minor) problem. Sorry. As workaround please use shortcuts the installer provide for you (in Programs menu, on Desktop, in QuickLaunch panel).