Right clic on versionned file can be long

Bug #271824 reported by Alexandre Garnier
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Bazaar Plugin for Eclipse
Fix Released
High
Guillermo Gonzalez

Bug Description

When I do a right clic on editor for versionned file, it can be long before seeing context menu.

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

The popup menu has a slight delay
This is probably caused by the current implementation of the popup menu, that checks if each action can be executed (in advance) and enable/disable them.
If you think this delay is unacceptable, an option could be added to the preference page (performance page, I suppose) to disable this pre-check of each action.

Regards,

Changed in bzr-eclipse:
status: New → Incomplete
Revision history for this message
Alexandre Garnier (zigarn) wrote :

After the context menu opens, there is no delay to open it during 2-3 seconds.
Isn't it possible to check activation of Team sub-menu after the display of the context menu ?
What are the checks which are so long -- ~10-15 seconds in my case (long history ~30000 revisions and large project ~20000 files)

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Apologize for the delay.
The team submenu can't be checked after the display of the context menu (as far I know). I'm going to further investigate if it's possible or what are the options to avoid this problem.

In the meantime, I propose to avoid the pre-checking of action enablement and show all actions. if an action can't be executed, show a popup with a brief explanation like: "The Action X can't be executed in this context"

What do you think?

Regards,

Changed in bzr-eclipse:
importance: Undecided → High
status: Incomplete → Confirmed
Revision history for this message
Alexandre Garnier (zigarn) wrote :

It's a good workaround.
The choice between this behaviour and the current will be configurable in the performance page ?

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Yes, in Preferences -> Bazaar -> Performance. i.e: "Check action availability" or "Check action enablement"

Cheers,

Changed in bzr-eclipse:
assignee: nobody → guillo.gonzo
status: Confirmed → In Progress
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

I just committed the "workaround" of adding an option to the perfomance preference page.
I'll be uploading a new build ASAP.

Changed in bzr-eclipse:
status: In Progress → Fix Committed
Changed in bzr-eclipse:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.