Bazaar Plugin for Eclipse

race condition in bzr uncommit

Bug #260409 reported by Radim Kolář
2
Affects Status Importance Assigned to Milestone
Bazaar Plugin for Eclipse
Fix Released
Medium
Guillermo Gonzalez

Bug Description

There is race condition in bzr uncommit function. BZR uncommit doesnt use -r REVISON command line argument. Its possible to uncommit different revision than intended if someone commited into branch in time window between confirmation dialog and bzr uncommit command invocation.

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Hi Radim,
Thanks for reporting this.
As I understand, his only could happen when you access the branch from outside eclipse, and run a commit from i.e: the CLI.
I think that a possible solution is to get a branch lock and don't allow changes in the branch until the uncommit dialog is closed.

Regards.

Changed in bzr-eclipse:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

I added a check to uncommit, so before executing it, the last revision is fetched and compared against the one the user accepted to uncommit.

Changed in bzr-eclipse:
assignee: nobody → verterok
status: Confirmed → Fix Committed
Guillermo Gonzalez (verterok)
Changed in bzr-eclipse:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.