import wizard does not display

[Luis Arias]

I consistently get the following exception when trying to run the import wizard after clicking Next on the Eclipse import dialog box.

Error
Mon Oct 29 16:04:15 CET 2007
Unhandled event loop exception

java.lang.NullPointerException
 at org.vcs.bazaar.eclipse.ui.wizards.CloneRepoWizardCreateRepoLocationPage.dispose(CloneRepoWizardCreateRepoLocationPage.java:225)
 at org.vcs.bazaar.eclipse.ui.wizards.CloneRepoWizard.dispose(CloneRepoWizard.java:112)
 at org.eclipse.jface.wizard.WizardDialog.hardClose(WizardDialog.java:790)
 at org.eclipse.jface.wizard.WizardDialog.close(WizardDialog.java:427)
 at org.eclipse.jface.window.Window.handleShellCloseEvent(Window.java:736)
 at org.eclipse.jface.window.Window$3.shellClosed(Window.java:682)
 at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:91)
 at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
 at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1101)
 at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1125)
 at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1110)
 at org.eclipse.swt.widgets.Shell.closeWidget(Shell.java:542)
 at org.eclipse.swt.widgets.Shell.gtk_delete_event(Shell.java:922)
 at org.eclipse.swt.widgets.Widget.windowProc(Widget.java:1478)
 at org.eclipse.swt.widgets.Control.windowProc(Control.java:4234)
 at org.eclipse.swt.widgets.Display.windowProc(Display.java:3973)
 at org.eclipse.swt.internal.gtk.OS._gtk_main_do_event(Native Method)
 at org.eclipse.swt.internal.gtk.OS.gtk_main_do_event(OS.java:5593)
 at org.eclipse.swt.widgets.Display.eventProc(Display.java:1192)
 at org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(Native Method)
 at org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:1487)
 at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2969)
 at org.eclipse.jface.window.Window.runEventLoop(Window.java:820)
 at org.eclipse.jface.window.Window.open(Window.java:796)
 at org.eclipse.ui.actions.ImportResourcesAction.run(ImportResourcesAction.java:159)
 at org.eclipse.ui.actions.BaseSelectionListenerAction.runWithEvent(BaseSelectionListenerAction.java:168)
 at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:546)
 at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:490)
 at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:402)
 at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
 at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1101)
 at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3319)
 at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2971)
 at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2389)
 at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2353)
 at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2219)
 at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
 at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
 at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
 at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
 at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
 at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:169)
 at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
 at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
 at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
 at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:508)
 at org.eclipse.equinox.launcher.Main.basicRun(Main.java:447)
 at org.eclipse.equinox.launcher.Main.run(Main.java:1173)

[Guillermo Gonzalez (verterok)]

I can't reproduce it, but I'm going add a "not null" check to prevent the stack trace

[Luis Arias (kaaloo)]

Hi Guillermo,

I checked this out in the debugger and I found the wizard page's
dispose() method is being called twice because the Wizard.dispose()
method already calls each pages dispose(). I'm submitting this small
patch to you hoping that it is in the right format.

I'll take a look around if there are other instances of this.

Luis

On 10/29/07, Guillermo Gonzalez <email address hidden> wrote:
> I can't reproduce it, but I'm going add a "not null" check to prevent
> the stack trace
>
> ** Changed in: bzr-eclipse
> Assignee: (unassigned) => Guillermo Gonzalez (guillo.gonzo)
> Status: New => In Progress
>
> --
> import wizard does not display
> https://bugs.launchpad.net/bugs/158350
> You received this bug notification because you are a direct subscriber
> of the bug.
>

--
Luis Arias
CTO
http://www.docxa.com
[phone]
skype : kaaloo

[Guillermo Gonzalez (verterok)]

Thanks!
It seems the patch was filtered.
You are right, the problem is that dispose is called twice, I think that the root of the problem, is the override of the dispose method in CloneRepoWizard.