Files in conflict have commit and shelve actions

Bug #1182003 reported by Alexander Taler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Plugin for Eclipse
Fix Released
Low
Piotr Piastucki

Bug Description

When a file is in a conflict state (e.g. from an update) the shelve and commit actions should not be available for it. Bazaar will refuse to commit a file in conflict, but apparently will allow it to be shelved which seems like a Bazaar bug.

In bzr-eclipse those actions should be greyed out.

Revision history for this message
Alexander Taler (alex-idereal) wrote :

In fact, commit actions should be greyed out everywhere as long as there's a file in conflict, because Bazaar will refuse to commit.

Changed in bzr-eclipse:
milestone: none → 1.3
status: New → Confirmed
Changed in bzr-eclipse:
importance: Undecided → Low
assignee: nobody → Piotr Piastucki (piastucki)
Changed in bzr-eclipse:
status: Confirmed → In Progress
Revision history for this message
Piotr Piastucki (piastucki) wrote :

I think there is nothing wrong in using shelve with files in conflict.
As for the commit action, I agree it should be disabled as long as there is at least 1 conflict in the branch. However, this means we will need to get the list of conflict on each right click and this will impact the user experience.
Maybe we can simply disable the OK button in the commit dialog? Or show a warning box informing the user about the conflicts instead?

Revision history for this message
Piotr Piastucki (piastucki) wrote :

I left shelve action as it is. Commit action will show a warning instead of the commit dialog if there are any conflicts found among the selected resources.

Changed in bzr-eclipse:
status: In Progress → Fix Committed
Changed in bzr-eclipse:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.