bzr-eclipse shows a strange warning dialog after install

[Alexander Taler]

After installation, when running the bzr-eclipse New Project Wizard, I get a strange warning message. This warning message only scares the user, and should not be necessary, bzr-eclipse can check its own dependencies. Does it actually refer to anything any more?

  A new version of the bzr Eclipse plugin has been installed, and the dependencies of this version might have changed.

  Please check if your system fulfill the new dependencies:

  http://bazaar-vcs.org/BzrEclipse

[Piotr Piastucki (piastucki)]

Xmloutput plugin seems to be the only real dependency, but it is already bundled with bzr-eclipse and the bundled version is enabled by default. I do not think we need to show the warning any more.

[Piotr Piastucki (piastucki)]

I would like to fix the issue in the following way:
1) remove the warning completely
2) remove the option to disable bundled plugins

The changes will simplify the setup as it should not be needed to check or install manually a correct version of xmloutput plugin. They will also make our lives easier as we can focus on supporting only the bundled version of xmlouput.
Hence xmloutput seems to be the only external dependency of bzr-eclipse it does not make much sense to show the warning.

[Piotr Piastucki (piastucki)]

Looking at the UI and the source code of the preference page I decided to make a couple of additional changes:
1) fix validation in Apply and OK actions
2) fix disappearing error message
3) set default executable path to the autodetected value so that users will be able to see it
4) remove Recheck button (it does exactly the same thing as Apply button)

I am wondering if we can remove "Bazaar plugin path" setting too. Is it really useful? We do not use any additional plugins in bzr-eclipse except xmloutput which is bundled with bzr-eclipse and rewrite which is needed only if rebase action is used.

I am inclined to remove the setting and simplify the preference page even more, any thoughts?

[Alexander Taler (alex-idereal)]

I agree with the changes you have made, simple is better.

Verified that this dialog is gone in the latest trunk build, and the disabled bundled plugins option is gone.

Let's create a new bug for removing the Bazaar plugin path setting and target it for 1.3.