New project wizard too quiet while downloading

Bug #1170254 reported by Alexander Taler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Plugin for Eclipse
Fix Released
Medium
Piotr Piastucki

Bug Description

When I'm using the new project wizard to download something, e.g. bzr-eclipse itself, the UI gives no indication that anything is happening in the background. For a large project it can stay in this state for quite a while which is unnerving.

The UI should provide some feedback that something is happening in the background so I don't just go ahead and cancel it.

Related branches

Changed in bzr-eclipse:
milestone: none → 1.2
Revision history for this message
Piotr Piastucki (piastucki) wrote :

It would be great to show the actual progress. Unfortunately, such a feature would require quite a few changes in xmloutput (UIFactory) and bzr-java-lib. And of course we will need to find a good way to pass the progress info from xmloutput to java code (socket? file?).

Revision history for this message
Alexander Taler (alex-idereal) wrote :

Yes, I was thinking exactly the same thing. At the least we should just add a message, saying "Accessing remote branch" or similar.

Revision history for this message
Piotr Piastucki (piastucki) wrote :

OK, here is a proof of concept:
1) bzr-xmloutput lp:~piastucki/bzr-xmloutput/progress-monitor
2) bzr-java-lib lp:~piastucki/bzr-java-lib/progress-monitor
It introduces and a new XMLRPC command called 'get_bzr_progress'. There is a simple polling mechanism in bzr-java-lib that will ask for progress update every 0.5sec and report it to a listener passed along with a command. A test case is added to BazaarClientTest.
Java code involved some internal refactoring related to passing Command object rather than a List<String> (desired anyway) and some API changes for selected commands. Currently the feature is supported in branch and checkout commands.
The changes in bzr-xmloutput are rather ugly due to an additional instance of XMLRPC server (I used port+1). Unfortunately the XMLRPC server in Python is single-threaded by default and I am hesitant to change this behaviour for all calls.

The value passed to progress listeners is exactly the same as the one shown in the console.

Changed in bzr-eclipse:
assignee: nobody → Piotr Piastucki (piastucki)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Piotr Piastucki (piastucki) wrote :

I've just committed a fix. Please test and let me know what you think.

Changed in bzr-eclipse:
status: In Progress → Fix Committed
Revision history for this message
Piotr Piastucki (piastucki) wrote :

Here is what the result looks like on Linux

Revision history for this message
Alexander Taler (alex-idereal) wrote :

I've been trying it out, looks really good so far, nice.

Verified, the fix is there in latest trunk version.

Changed in bzr-eclipse:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.