"bzr commit" does not trigger DBus signal for recent branch formats

Bug #198645 reported by James Henstridge on 2008-03-05
2
Affects Status Importance Assigned to Milestone
bzr-dbus
Medium
Unassigned

Bug Description

While testing bzr-dbus with bzr-1.2, I noticed that no DBus "Revision" signal was being broadcast when I committed to a pack format branch. It seems that the "set_rh" hook was not being called.

The set_revision_history() method is not being called for branch formats newer than dirstate-tags during commit, so bzr-dbus misses the branch change. I guess it should be changed to listen to a different set of hooks (some combination of post_commit, post_uncommit, post_pull and post_push).

On IRC Aaron suggested that a bzr hook for set_revision_info() might be appropriate.

Related branches

description: updated
James Henstridge (jamesh) wrote :

As of r3361, bzr has a post_change_branch_tip hook that could be used to fix this bug.

James Henstridge (jamesh) wrote :

The attached branch uses the post_change_branch_tip hook in preference to set_rh if it is available. If we don't care about older versions of bzr, it'd be cleaner to just use the new hook unconditionally.

Jelmer Vernooij (jelmer) on 2008-12-05
Changed in bzr-dbus:
importance: Undecided → Medium
status: New → Fix Committed
Changed in bzr-dbus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers