bazaar dbus plugin aborts commit one the broadcast service crashes

[Martin Pool]

If the plugin can't talk to dbus, it should just give a warning, not abort the commit. (This happened while I was upgrading; dbus may be broken at the moment.)

mbp@hope [1 job]% bzr commit -m foo
bzr Installed bzr version 0.15.0 is too old to be used with bzr-gtk 0.16.0.
Unable to load plugin 'gtk' from '/home/mbp/.bazaar/plugins'
/ [====================================================================================================== ] Committing 130/133phbzr: ERROR: dbus.DBusException: org.freedesktop.DBus.Error.Spawn.ChildExited: Process /usr/bin/bzr exited with status 1

Traceback (most recent call last):
  File "/home/mbp/lib/python/bzrlib/commands.py", line 650, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/home/mbp/lib/python/bzrlib/commands.py", line 612, in run_bzr
    ret = run(*run_argv)
  File "/home/mbp/lib/python/bzrlib/commands.py", line 304, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/mbp/lib/python/bzrlib/builtins.py", line 2118, in run
    reporter=reporter)
  File "/home/mbp/lib/python/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/home/mbp/lib/python/bzrlib/workingtree_4.py", line 244, in commit
    result = WorkingTree3.commit(self, message, revprops, *args, **kwargs)
  File "/home/mbp/lib/python/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/home/mbp/lib/python/bzrlib/mutabletree.py", line 160, in commit
    revprops=revprops, *args, **kwargs)
  File "/home/mbp/lib/python/bzrlib/commit.py", line 353, in commit
    self.branch.set_last_revision_info(new_revno, self.rev_id)
  File "/home/mbp/lib/python/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/home/mbp/lib/python/bzrlib/branch.py", line 1389, in set_last_revision_info
    self.set_revision_history(history)
  File "/home/mbp/lib/python/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/home/mbp/lib/python/bzrlib/branch.py", line 1382, in set_revision_history
    hook(self, rev_history)
  File "/home/mbp/.bazaar/plugins/dbus/hook.py", line 41, in on_set_rh
    activity.Activity().advertise_branch(branch)
  File "/home/mbp/.bazaar/plugins/dbus/activity.py", line 75, in advertise_branch
    self.announce_revision(branch.last_revision(), branch.base)
  File "/home/mbp/.bazaar/plugins/dbus/activity.py", line 86, in announce_revision
    self._call_on_broadcast('announce_revision', revision, url)
  File "/home/mbp/.bazaar/plugins/dbus/activity.py", line 106, in _call_on_broadcast
    Broadcast.DBUS_PATH)
  File "/var/lib/python-support/python2.5/dbus/_dbus.py", line 410, in get_object
    follow_name_owner_changes=follow_name_owner_changes)
  File "/var/lib/python-support/python2.5/dbus/proxies.py", line 230, in __init__
    _dbus_bindings.UInt32(0))
  File "/var/lib/python-support/python2.5/dbus/proxies.py", line 169, in __call__
    reply_message = self._connection.send_message_with_reply_and_block(message, timeout)
DBusException: org.freedesktop.DBus.Error.Spawn.ChildExited: Process /usr/bin/bzr exited with status 1

bzr 0.15.0 on python 2.5.1.candidate.1 (linux2)
arguments: ['/home/mbp/bin/bzr', 'commit', '-m', 'foo']

** please send this report to <email address hidden>
zsh: exit 3 bzr commit -m foo
bzr commit -m foo 1.34s user 0.16s system 18% cpu 8.044 total

[Robert Collins (lifeless)]

 status confirmed
 importance high

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Robert Collins (lifeless)]

Possibly fixed with recent trunk.

[Thomas E Jenkins (thomas-jenkins)]

I hit something similar with "bzr viz" though the dbus error message is slightly different. I'm guessing the fix for this bug will probably fix my error as well so I've not opened a new report. Removing bzr-avahi and bzr-dbus allows "bzr viz" to function properly. Error output below.

mort@pickle:~/work/EMC-SMF/devel/obiee-access$ bzr viz
bzr: ERROR: dbus.exceptions.DBusException: org.freedesktop.DBus.Error.Spawn.ChildExited: Launch helper exited with unknown return code 0

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 893, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 839, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 539, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/__init__.py", line 288, in run
    pp = start_viz_window(br, revids, limit)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/__init__.py", line 256, in start_viz_window
    from bzrlib.plugins.gtk.viz import BranchWindow
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/viz/__init__.py", line 14, in <module>
    from branchwin import BranchWindow
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/viz/branchwin.py", line 18, in <module>
    from bzrlib.plugins.gtk.tags import AddTagDialog
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/tags.py", line 27, in <module>
    from bzrlib.plugins.gtk.revisionview import RevisionView
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/revisionview.py", line 32, in <module>
    from bzrlib.plugins.gtk import seahorse
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/seahorse.py", line 33, in <module>
    crypto = dbus.Interface(bus.get_object(BUS_NAME, CRYPTO_PATH),
  File "/var/lib/python-support/python2.5/dbus/bus.py", line 244, in get_object
    follow_name_owner_changes=follow_name_owner_changes)
  File "/var/lib/python-support/python2.5/dbus/proxies.py", line 241, in __init__
    self._named_service = conn.activate_name_owner(bus_name)
  File "/var/lib/python-support/python2.5/dbus/bus.py", line 183, in activate_name_owner
    self.start_service_by_name(bus_name)
  File "/var/lib/python-support/python2.5/dbus/bus.py", line 281, in start_service_by_name
    'su', (bus_name, flags)))
  File "/var/lib/python-support/python2.5/dbus/connection.py", line 622, in call_blocking
    message, timeout)
DBusException: org.freedesktop.DBus.Error.Spawn.ChildExited: Launch helper exited with unknown return code 0

bzr 1.11 on python 2.5.4 (linux2)
arguments: ['/usr/bin/bzr', 'viz']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'de_DE.UTF-8'
plugins:
  avahi /usr/lib/python2.5/site-packages/bzrlib/plugins/avahi [0.3dev]
  bzrtools /usr/lib/python2.5/site-packages/bzrlib/plugins/bzrtools [1.11]
  dbus /usr/lib/python2.5/site-packages/bzrlib/plugins/dbus [unknown]
  gtk /usr/lib/python2.5/site-packages/bzrlib/plugins/gtk [0.95.0.final.1]
  launchpad /usr...