cvsps-import imports $CVSROOT/CVSROOT

[Mark Chernev]

cvsps-import revno: 57
Bazaar (bzr) 0.91.0

"bzr cvsps-import $CVSROOT . output" imports $CVSROOT/CVSROOT, even though it contains nothing but CVS metadata that's useless to the user once the import is completed.

So, the way it stands now, the user would have to manually delete CVSROOT from his repository after the import is complete, whereas it should have never been imported in the first place.

In a discussion on #bzr it was suggested that a cvsps-import have a switch option to allow $CVSROOT/CVSROOT to be imported, in the corner cases where a user may want the CVS metadata after all.

[Matthew Fuller (fullermd)]

To restate my stance from IRC:

I think the more likely bug is that cvsps-import [easily] lets you
import the root of the repository. While you CAN use CVS in that way,
I've never heard anybody recommend it without chemical assistance, and
actually _using_ CVS that way would be remarkably unpleasant. So, I
tend to think that trying to import the root of the repo is more
likely to be a user error than a real request, and the proper response
isn't "ignore CVSROOT/", but rather "refuse [in the absence of
--force]". And if they really DO want to import the whole repo as one
branch, I tend to think they may well want CVSROOT/ too.

If somebody REALLY wants to import the root of the repo, but without
CVSROOT/, it can be done by manipulation of ignore patterns.
Realistically, only via ~/.bazaar/ignore. Perhaps cvsps-import should
allow some way to pre-seed the tree so you could stuff a .bzrignore in
there ahead of time; that would also allow pre-setting the format of
the target branch, etc.

[Matthew Fuller (fullermd)]

Whoops, this should file under cvsps-import, not bzr

[John A Meinel (jameinel)]

There should probably be a way to filter whatever you want.

I know in *my* limited CVS usage, I used the whole tree. I had subprojects, but I frequently did a root-level checkout so that my working area ways setup with my different projects.

[John A Meinel (jameinel)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

fullermd wrote:

...

> If somebody REALLY wants to import the root of the repo, but without
> CVSROOT/, it can be done by manipulation of ignore patterns.
> Realistically, only via ~/.bazaar/ignore. Perhaps cvsps-import should
> allow some way to pre-seed the tree so you could stuff a .bzrignore in
> there ahead of time; that would also allow pre-setting the format of
> the target branch, etc.
>

Well, cvsps-import ignores ~/.bazaar/ignore. It isn't creating a CVS checkout
and then doing "bzr commit". It is instead loading things into memory and
handing that pretend tree to the commit code.

It would be reasonable to have a bit of configuration to allow you to specify
what does and doesn't get converted. But then you start to lose the "ease of
use". Because you have a big config to set up, etc. Rather than just

  bzr cvsps-import root module out

I wonder if doing module = '.' should just trigger a conversion on each
submodule. That would certainly be possible, too.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHIPo3JdeBCYSNAAMRAi9PAJ4nFHq8EIJzz1VesesFpN2Kxj8MOQCgwvJW
wqiiezOfY8e6/DuDVLFlyoI=
=UAMN
-----END PGP SIGNATURE-----