bzr merge-upstream crashes if no version is given
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
bzr-builddeb |
Fix Released
|
Medium
|
Jelmer Vernooij |
Bug Description
If only the upstream tarball is given to merge-upstream, it crashes:
$ bzr mu ../zope.
Using distribution precise
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "/usr/lib/
return the_callable(*args, **kwargs)
File "/usr/lib/
ret = run(*run_argv)
File "/usr/lib/
return self.run(
File "/usr/lib/
return self._operation
File "/usr/lib/
self.cleanups, self.func, *args, **kwargs)
File "/usr/lib/
result = func(*args, **kwargs)
File "/usr/lib/
assert isinstance(version, str)
AssertionError
This means that no "--version" parameter was given. It should at least print a human-readable error message and exit(1), not assert.
In other case when not enough information is given -- only the version, not the upstream tarball -- bzr-builddeb uses debian/watch to download the needed file. Maybe similar approach (or uscan) can be used here to automatically guess the version number from upstream (or .orig.tar.gz) file name.
ProblemType: Crash
DistroRelease: Ubuntu 12.04
Package: bzr 2.5.0~beta4-
ProcVersionSign
Uname: Linux 3.2.0-7-generic-pae i686
NonfreeKernelMo
ApportVersion: 1.90-0ubuntu1
Architecture: i386
BzrDebugFlags: set()
BzrVersion: 2.5b4
CommandLine: ['/usr/bin/bzr', 'mu', '../zope.
CrashDb: bzr
Date: Tue Jan 3 16:13:31 2012
ExecutablePath: /usr/bin/bzr
FileSystemEncoding: UTF-8
InterpreterPath: /usr/bin/python2.7
Locale: lt_LT.UTF-8
PackageArchitec
Platform: Linux-3.
ProcCmdline: /usr/bin/python /usr/bin/bzr mu ../zope.
PythonVersion: 2.7.2
SourcePackage: bzr
Title: bzr crashed with AssertionError in run()
UpgradeStatus: Upgraded to precise on 2011-12-29 (4 days ago)
UserEncoding: UTF-8
UserGroups: adm admin cdrom dialout dip libvirtd lpadmin plugdev sambashare
Related branches
- James Westby: Approve
-
Diff: 217 lines (+84/-48)4 files modifiedcmds.py (+59/-42)
debian/changelog (+3/-1)
tests/test_upstream.py (+14/-1)
upstream/__init__.py (+8/-4)
Changed in bzr-builddeb: | |
status: | Confirmed → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Jelmer Vernooij (jelmer) |
milestone: | none → 2.8.1 |
Changed in bzr-builddeb: | |
status: | In Progress → Fix Committed |
Changed in bzr-builddeb: | |
status: | Fix Committed → Fix Released |
This is fixed in newer versions of bzr-builddeb.