merge-upstream blows up if a criss cross is found

Bug #515367 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bzr-builddeb
Fix Released
Undecided
Unassigned

Bug Description

This causes a 'no merge base' error because there are two lcas found.

Its a little complex, but I have

debian:
debtrunk
 upstream-0.1
maintrunk
...

upstream;
newstuff
maintrunk
...

So the import does:

upstream-0.2: [upstream-0.1, newstuff]
and then a merge of upstream-0.2 into debian: find_lca finds
upstream-0.1 and maintrunk as common ancestors. However, because
upstream-0.1 does not have maintrunk in its ancestry an error is thrown
- no merge base.

This is arguably an error in my tree - I blogged
http://rbtcollins.wordpress.com/2009/12/19/debianising-with-bzr-builddeb/ about debianising with bzr-builddeb, and it appears that the upstream import it creates is missing a link to the trunk. (This is another reason to have a few smaller steps exposed so the hackery in that blog post is not needed and we can get cleaner data).

However, I think it might be nice to, when a no-merge-base is found
during merge-upstream, force the previous upstream tarball as a common
base, because we should expect it to be there and sane.

I'm looking at whether this is easy or not now.

 affects bzr-builddeb

Related branches

Changed in bzr-builddeb:
status: New → Fix Committed
James Westby (james-w)
Changed in bzr-builddeb:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.