Should either accept options with no section in config files, or warn about them

Bug #309335 reported by Alexander Sack
4
Affects Status Importance Assigned to Milestone
bzr-builddeb
Fix Released
Medium
Unassigned
bzr-builddeb (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: bzr-builddeb

ii bzr-builddeb 2.0.2~0ubuntu2 bzr plugin for Debian package management

1. bzr branch lp:~ubuntu-dev/firefox-extensions/bugmail.ubuntu; cd bugmail.ubuntu

2. $ cat .bzr-builddeb/default.conf
merge = True
export-upstream = .
export-upstream-revision = revid:<email address hidden>

3. bzr bd
 => fails to find/create orig

4. bzr bd --merge --export-upstream=. --export-upstream-revision=revid:<email address hidden>
 => works

Related branches

Revision history for this message
Alexander Sack (asac) wrote :

we have other branches where this works. maybe a special case as the revid: referred to is in fact revision 1 of the tree (using just 1 instead of revid: doesnt help though)

Changed in bzr-builddeb:
importance: Undecided → Medium
status: New → Confirmed
status: Confirmed → Triaged
Revision history for this message
James Westby (james-w) wrote :

Hi,

Thanks for the bug report. Please provide the output when the command
fails.

Thanks,

James

Changed in bzr-builddeb:
status: Triaged → Incomplete
Revision history for this message
Saša Bodiroža (jazzva) wrote : Re: [Bug 309335] Re: .bzr-builddeb/default.conf doesnt export-upstream in some cases

Hello James,

Here is the output for both cases.

sasa@cakana:~/Devel/bugmail/bugmail.ubuntu$ bzr bd
Building using working tree
Preparing the build area: ../build-area
Looking for ../bugmail-extension_1.3.orig.tar.gz to use as upstream source
For compatibility looking for
../tarballs/bugmail-extension_1.3.orig.tar.gz to use as upstream source
There is no debian/watch file, so can't use that to retrieve upstream
tarball
bzr: ERROR: A Debian packaging error occurred: Could not find upstream
tarball at ../bugmail-extension_1.3.orig.tar.gz

sasa@cakana:~/Devel/bugmail/bugmail.ubuntu$ bzr bd --merge
--export-upstream=.
--export-upstream-revision=revid:<email address hidden>
Building using working tree
Running in merge mode
Preparing the build area: ../build-area
Exporting to ../build-area/bugmail-extension-1.3 in merge mode
Exporting upstream source from ., revision
<email address hidden>
bugmail-extension-1.3
Exporting debian/ part to ../build-area/bugmail-extension-1.3
Building the package in ../build-area/bugmail-extension-1.3, using
dpkg-buildpackage -uc -us -rfakeroot
...

--
Saša

Revision history for this message
Alexander Sack (asac) wrote : Re: .bzr-builddeb/default.conf doesnt export-upstream in some cases

easy instructions how to reproduce were provided ;) ... if you dont see it let us know.

Changed in bzr-builddeb:
status: Incomplete → Triaged
James Westby (james-w)
Changed in bzr-builddeb:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Is .bzr-builddeb/default.conf versioned? It needs to be, in order for bzr-builddeb to use it.

Revision history for this message
Alexander Sack (asac) wrote : Re: [Bug 309335] Re: .bzr-builddeb/default.conf doesnt export-upstream in some cases

On Fri, Dec 19, 2008 at 07:58:55PM -0000, Jelmer Vernooij wrote:
> Is .bzr-builddeb/default.conf versioned? It needs to be, in order for
> bzr-builddeb to use it.
>

Yes, its committed to the branch.

 - Alexander

Revision history for this message
James Westby (james-w) wrote :

Hi,

The issue is that there is no "[BUILDDEB]" line at the top of .bzr-builddeb/default.conf.

I've changed the bug report to state that this should be handled better.

Thanks,

James

Changed in bzr-builddeb:
status: Confirmed → Triaged
James Westby (james-w)
Changed in bzr-builddeb:
status: Triaged → Fix Committed
milestone: none → 2.1
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bzr-builddeb - 2.1

---------------
bzr-builddeb (2.1) experimental; urgency=low

  * Merge the tags from the upstream branch when doing merge-upstream with
    a branch.
  * Catch and wrap ChangelogParseError to avoid the traceback (LP: #215732)
  * Warn when a key is defined outside of any sections in a config file.
    (LP: #309335)
  * Warn when the user uses the deprecated --result option. (LP: #268675)
  * Add "--release-heuristic changelog" to dch call after merge-upstream so
    that UNRELEASED entries are edited rather than a new stanza added.
    (Closes: #515921, LP: #331994)
  * Allow specifying the merge type in merge-upstream (LP: #310694)
  * Make merge mode work with Python 2.6 (LP: #336686)
  * Give a more informative message if pristine-tar isn't installed.
    (LP: #336442)
  * Record extra authors in import-dsc based on what is in the changelog
    entry (LP: #335071)
  * Provide a commit message template based on additions to debian/changelog,
    similar to debcommit. Bump version of bzr required to 1.10, which is the
    release that introduced the hook. (Closes: #497415, LP: #331993)
  * Give a better error if the pristine upstream branch can't be located.
    (Closes: #517869)

 -- James Westby <email address hidden> Thu, 05 Mar 2009 13:49:44 +0000

Changed in bzr-builddeb:
status: Triaged → Fix Released
James Westby (james-w)
Changed in bzr-builddeb:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.