catch and wrap ChangelogParseError so that it doesn't traceback

[Christer Edwards]

I am fairly new to bzr and my guess is this is all likely caused by some breakage in my changelog (as mentioned below), but the output suggests a report so I figure what the hell..

I'm running ubuntu 8.04 beta
Bazaar (bzr) 1.3.1rc1
  Python interpreter: /usr/bin/python 2.5.2.final.0
  Python standard library: /usr/lib/python2.5
  bzrlib: /usr/lib/python2.5/site-packages/bzrlib
  Bazaar configuration: /home/christer/.bazaar
  Bazaar log file: /home/christer/.bzr.log

christer@007:~/origami/debian$ bzr-buildpackage --native
Running in native mode
Building using working tree
bzr: ERROR: debian_bundle.changelog.ChangelogParseError: Could not parse changelog: --Christer Edwards <email address hidden> Wed, 09 Apr 2008 23:53:00 -600

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 834, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 790, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 492, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/builddeb/__init__.py", line 238, in run
    (changelog, larstiq) = find_changelog(t, merge)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/builddeb/util.py", line 83, in find_changelog
    changelog.parse_changelog(contents, max_blocks=1, allow_empty_author=True)
  File "/var/lib/python-support/python2.5/debian_bundle/changelog.py", line 261, in parse_changelog
    raise ChangelogParseError(line)
ChangelogParseError: Could not parse changelog: --Christer Edwards <email address hidden> Wed, 09 Apr 2008 23:53:00 -600

bzr 1.3.1rc1 on python 2.5.2.final.0 (linux2)
arguments: ['/usr/bin/bzr', 'builddeb', '--native']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  builddeb /usr/lib/python2.5/site-packages/bzrlib/plugins/builddeb [0.92.0dev0]
  bzrtools /usr/lib/python2.5/site-packages/bzrlib/plugins/bzrtools [1.3.0]
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

[James Westby (james-w)]

On Fri, 2008-04-11 at 14:56 +0000, Christer Edwards wrote:
> Public bug reported:
>
> I am fairly new to bzr and my guess is this is all likely caused by some
> breakage in my changelog (as mentioned below), but the output suggests a
> report so I figure what the hell..
>

Hi Christer,

Welcome to the world of bzr. You are correct that this is a problem
with the fomat of your changelog.

> ChangelogParseError: Could not parse changelog: --Christer Edwards <email address hidden> Wed, 09 Apr 2008 23:53:00 -600

There's a space missing after the "--" and before your name.

You can find the format documented at

  http://www.debian.org/doc/debian-policy/ch-source.html

section 4.4.

You may be interested in the "dch" tool in the "devscripts" package.
That can take care of handling all of the format etc., leaving you
just to write the message.

I think this error could be a lot nicer though, so I should change
that.

Thanks,

James

[Aaron Bentley (abentley)]

Thanks for reporting the bug, but it's actually in bzr-buildpackage, which doesn't use Launchpad as its bug tracker.

[Wouter van Heyst (larstiq)]

On Sun, Feb 08, 2009 at 09:53:09PM -0000, Launchpad Bug Tracker wrote:
> You have been subscribed to a public bug:
>
> I am fairly new to bzr and my guess is this is all likely caused by some
> breakage in my changelog (as mentioned below), but the output suggests a
> report so I figure what the hell..

Yeah, bzr-builddeb uses python-debian to parse changelogs, the problem
is indeed with your changelog.

> bzr: ERROR: debian_bundle.changelog.ChangelogParseError: Could not parse changelog:

      --Christer Edwards <email address hidden> Wed, 09 Apr 2008 23:53:00 -600

Try a space between the -- and your name, ie ' -- Crhister Edwards ...'

Wouter