Dosen't compile off latest bzr-java-lib

Bug #551964 reported by Ian Brandt on 2010-03-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bzr-ant
Low
Ian Brandt

Bug Description

BzrTask$AntMessageHandler implements IBazaarNotifyListener interface, and @Override is not valid for "implements": http://blogs.sun.com/ahe/entry/override. Patch attached.

$ ant
Buildfile: build.xml

compile:
    [javac] Compiling 8 source files to /Users/ibrandt/Development/bzr-ant/bin
    [javac] /Users/ibrandt/Development/bzr-ant/src/org/scm/bazaar/ant/BzrTask.java:103: method does not override a method from its superclass
    [javac] @Override
    [javac] ^
    [javac] /Users/ibrandt/Development/bzr-ant/src/org/scm/bazaar/ant/BzrTask.java:107: method does not override a method from its superclass
    [javac] @Override
    [javac] ^
    [javac] /Users/ibrandt/Development/bzr-ant/src/org/scm/bazaar/ant/BzrTask.java:111: method does not override a method from its superclass
    [javac] @Override
    [javac] ^
    [javac] /Users/ibrandt/Development/bzr-ant/src/org/scm/bazaar/ant/BzrTask.java:115: method does not override a method from its superclass
    [javac] @Override
    [javac] ^
    [javac] /Users/ibrandt/Development/bzr-ant/src/org/scm/bazaar/ant/BzrTask.java:120: method does not override a method from its superclass
    [javac] @Override
    [javac] ^
    [javac] /Users/ibrandt/Development/bzr-ant/src/org/scm/bazaar/ant/BzrTask.java:125: method does not override a method from its superclass
    [javac] @Override
    [javac] ^
    [javac] /Users/ibrandt/Development/bzr-ant/src/org/scm/bazaar/ant/BzrTask.java:130: method does not override a method from its superclass
    [javac] @Override
    [javac] ^
    [javac] /Users/ibrandt/Development/bzr-ant/src/org/scm/bazaar/ant/BzrTask.java:135: method does not override a method from its superclass
    [javac] @Override
    [javac] ^
    [javac] 8 errors

BUILD FAILED

----

bzr-ant $ bzr info -v
Standalone tree (format: 2a)
Location:
  branch root: .

Related branches:
  parent branch: http://bazaar.launchpad.net/~craighewetson/bzr-ant/trunk/

Format:
       control: Meta directory format 1
  working tree: Working tree format 6
        branch: Branch format 7
    repository: Repository format 2a - rich roots, group compression and chk inventories

In the working tree:
        22 unchanged
         1 modified
         0 added
         0 removed
         0 renamed
         3 unknown
         2 ignored
         7 versioned subdirectories

Branch history:
         3 revisions
       156 days old
   first revision: Sat 2009-10-24 21:53:01 +0200
  latest revision: Sun 2009-10-25 13:46:30 +0200

Repository:
         4 revisions

----

bzr-java-lib $ bzr info -v
Checkout (format: 2a)
Location:
       checkout root: .
  checkout of branch: http://bazaar.launchpad.net/~verterok/bzr-java-lib/bzr-java-lib/

Format:
       control: Meta directory format 1
  working tree: Working tree format 6
        branch: Branch format 7
    repository: Repository format 2a - rich roots, group compression and chk inventories

In the working tree:
       287 unchanged
         0 modified
         0 added
         0 removed
         0 renamed
         0 unknown
         1 ignored
        48 versioned subdirectories

Branch history:
       215 revisions
      1129 days old
   first revision: Sat 2007-02-24 21:29:06 -0300
  latest revision: Wed 2010-02-24 01:35:42 -0300

Repository:
       534 revisions

Related branches

Ian Brandt (ian-ianbrandt) wrote :
Ian Brandt (ian-ianbrandt) wrote :

Oops, patch should have been named bzr-ant-r3.patch. r215 was the bzr-java-lib revision.

Thank you for logging this. I've applied the patch.
NOTE, in eclipse ide it seems to generate those override annotations even if you implement and interface.
I personally think there should be an @implements annotate in java.

BTW: I haven't had a chance/time to work on anything new with this project, so if you need a new ant task or want to improved the build process feel free to contribute as you like.

Also: I think you will earn more karma points if you create a branch and then propose a merge request instead of attaching a patch to the bug (if you care about karma that is :) .
Its nice to see the developer's contribution in the actual log of the trunk.
And merge proposal's can get reviewed online in launchpad etc... actually very nice to do it that way.

Changed in bzr-ant:
status: New → Fix Committed
assignee: nobody → Craig Hewetson (craighewetson)
assignee: Craig Hewetson (craighewetson) → Ian Brandt (ian-ianbrandt)
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers