byobu should not set environment variable 'SED'

Reported by Scott Moser on 2012-01-23
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Buildroot
Won't Fix
Wishlist
byobu
High
Unassigned
byobu (Ubuntu)
High
Unassigned

Bug Description

byobu should not epxort the environment variable SED. SED is apparently read by some build systems, and having it set in the environment causes difficult to track down bugs. See https://bugs.busybox.net/show_bug.cgi?id=4429 for an example.

I suggest using a different byobu specific variable name if it is required that you export it.

The exporting of this variable came into byobu on 2011-07-20 in revision 1532 with message:
   * usr/lib/byobu/.constants:
    - need to export a couple of values for use in the profile

The other potential variable that might be in a too-global namespace is 'READLINK'.

ProblemType: Bug
DistroRelease: Ubuntu 11.10
Package: byobu 4.37-0ubuntu1
ProcVersionSignature: User Name 3.0.0-12.20-virtual 3.0.4
Uname: Linux 3.0.0-12-virtual x86_64
ApportVersion: 1.23-0ubuntu4
Architecture: amd64
Date: Mon Jan 23 21:02:31 2012
Ec2AMI: ami-000000e5
Ec2AMIManifest: FIXME
Ec2AvailabilityZone: nova
Ec2InstanceType: standard.xlarge
Ec2Kernel: aki-000000e4
Ec2Ramdisk: unavailable
PackageArchitecture: all
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ScreenRC:

SourcePackage: byobu
UpgradeStatus: No upgrade log present (probably fresh install)

Scott Moser (smoser) wrote :
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in byobu (Ubuntu):
status: New → Confirmed
jablko (ms419) wrote :
Scott Moser (smoser) wrote :

Just for anyone else who comes across this, the fix i made in cirros's Makefile (which can be applied anywhere else) was simply to add:
   unexport SED # causes random issues (LP: #920620)

Alternatively, you can just remember to run:
 unset SED
or
 env -u SED your-build-command-here

Dustin Kirkland  (kirkland) wrote :

THanks, I'll get this fixed.

Changed in byobu:
status: New → Triaged
Changed in byobu (Ubuntu):
status: Confirmed → Triaged
Changed in byobu:
importance: Undecided → High
Changed in byobu (Ubuntu):
importance: Undecided → High
Dustin Kirkland  (kirkland) wrote :

Moving $SED to our namespace, $BYOBU_SED.

Changed in byobu:
status: Triaged → In Progress
Changed in byobu (Ubuntu):
status: Triaged → In Progress
Changed in byobu:
status: In Progress → Fix Committed
Changed in byobu (Ubuntu):
status: In Progress → Fix Committed
Changed in byobu:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package byobu - 5.6-0ubuntu1

---------------
byobu (5.6-0ubuntu1) precise; urgency=low

  [ Dustin Kirkland ]
  * usr/lib/byobu/ip_address:
    - user@host and ipaddress need some separation, as they're hard to
      differentiate when next to one another
  * usr/bin/byobu-ctrl-a: LP: #922951
    - if the user has already chosen an escape sequence, don't run the
      interactive byobu-ctrl-a program
  * usr/share/byobu/keybindings/f-keys.tmux,
    usr/share/byobu/profiles/tmux:
    - empty default window names
    - easy to change with F8
    - need to save characters in default tmux launch to get it to fit
      in 80x24 terminals
  * experimental/byobu-classroom, usr/bin/byobu-config, usr/bin/byobu-
    ctrl-a, usr/bin/byobu-janitor, usr/bin/byobu-launcher-uninstall,
    usr/bin/byobu-quiet, usr/bin/byobu-silent, usr/bin/byobu-status,
    usr/lib/byobu/cpu_temp, usr/lib/byobu/custom,
    usr/lib/byobu/ec2_cost, usr/lib/byobu/include/constants,
    usr/lib/byobu/logo, usr/lib/byobu/menu, usr/lib/byobu/network,
    usr/share/byobu/keybindings/f-keys: LP: #920661
    - byobu should not set environment variable 'SED'
    - use BYOBU_SED instead
  * usr/bin/byobu, usr/bin/byobu-janitor, usr/lib/byobu/disk_io,
    usr/lib/byobu/include/constants:
    - use BYOBU_READLINK instead of READLINK
  * usr/bin/byobu-select-session: LP: #911500
    - detect and avoid some circular byobu-inside-byobu infinite loops
  * usr/bin/byobu, usr/bin/byobu-ctrl-a, usr/bin/byobu-reconnect-
    sockets, usr/lib/byobu/color, usr/lib/byobu/date,
    usr/lib/byobu/include/shutil, usr/lib/byobu/time:
    - make check for BYOBU_BACKEND explitly tmux|screen

  [ Ryan Thompson ]
  * usr/bin/byobu-select-session: LP: #919391
    - read only integers
  * usr/bin/byobu-select-session: LP: #908944
    - use attach_session function
 -- Dustin Kirkland <email address hidden> Wed, 18 Jan 2012 19:57:15 -0600

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
Changed in buildroot:
importance: Unknown → Wishlist
status: Unknown → Confirmed
Changed in buildroot:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.