Display both IPv4 and IPv6 addresses

Bug #898065 reported by Andrew McCarthy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu
Fix Released
Wishlist
Unassigned

Bug Description

At the moment I can choose to display either an IPv4 address *or* an IPv6 address, but not both together. Can the "ip_address" status notification be split in two, one for IPv4 (ip_address) and one for IPv6 (ip6_address, say)? Thanks!

Revision history for this message
Andrew McCarthy (andrewmccarthy) wrote :

The attached branch adds a new status, ip6_address, that displays to the left of ip_address. I've stripped out the IPv6 code from ip_address. Similar to IP_EXTERNAL there is now also IP6_EXTERNAL.

The IPV6 variable is now used in the main byobu script for setting the window title; I'm not convinced that's the nicest but is better than IPv4-only.

(Note, this is my first code contribution via bzr/launchpad. Do let me know if I've submitted anything incorrectly!)

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Thanks, for your contribution! I think it's a reasonable suggestion, though I think I have simpler approach, with less code duplication. I'll get this committed as soon as I get a chance.

Changed in byobu:
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Fix committed.

Now, in your ~/.byobu/status, just add ip_address4 and ip_address6 at the same time.

Changed in byobu:
status: Triaged → In Progress
status: In Progress → Fix Committed
Changed in byobu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.