byobu-shell doesn't display motd

[Paul Tansom]

Somewhat similar to my previous and quite similar bug report (https://bugs.launchpad.net/byobu/+bug/1458941), but with a different cause. After investigating why I was no longer getting the motd when booting into a byobu shell on ssh login I found that there is a .hushlogin file in my home directory. This is designed to suppress the motd. After further digging I've found that this is created when you enable launching of byobu on login from the byobu-config, and on digging still further to find exactly where this happens I've found that in byobu-launcher-install there are the lines (83 to 85 currently in the launchpad file):

# Hush login, since we will handle motd printing
touch "$HOME"/.hushlogin
rm -f "$BYOBU_CONFIG_DIR/disable-autolaunch"

This clashes with the lines in byobu-shell:

# Find a MOTD, seems that they're moving around
for i in /etc/motd /run/motd.dynamic /run/motd; do
        [ -r $i ] && [ ! -e "$HOME"/.hushlogin ] && cat $i && break
done

These were added/modified after the earlier referenced bug and check for the .hushlogin file. The problem seems to be that byobu isn't actually handling the motd printing as per the comment. I've not located where this might be yet though. I'm seeing this in 16.04 and in 14.04 if I apply the previous fix to the byobu-shell file (it doesn't seem to have filtered back into the previous releases).

[Dustin Kirkland  (kirkland)]

Hmm, motd is printing correctly here for me.

That for loop looks for the right motd, and concatenates it to screen.