a shell terminated at startup time when using wrapper script

Bug #1289157 reported by Kosuke Asami on 2014-03-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu
Medium
Unassigned

Bug Description

I wrote a wrapper that ensures byobu uses correct prefix for me.

The wrapper is like following line.

BYOBU_PREFIX="/usr/local" "/usr/local/Cellar/byobu/5.73/libexec/bin/byobu-launch" "$@"

I use this wrapper as a substitude of byobu-launch.

If I have byobu launch at login time, byobu-launch is executed in my .profile and .zprofile by byobu-launcher-install.

However, byobu-launch quits unless a shell is launched in interactive mode.
The wrapper doesn't launch a shell in interactive mode, so byobu-launch quits immediately and I cannot launch byobu.

This problem is solved by the attached patch.

However, even if the upper problem is solved, the wrapper doesn't work when the wrapper is like following line.

BYOBU_PREFIX="/usr/local" exec "/usr/local/Cellar/byobu/5.73/libexec/bin/byobu-launch" "$@"

When the inner command of exec quits, the shell itself also quits.
If it is not the first time launching, byobu-launch terminates at startup time and a shell cannot be launched.

Is this a corrent usage using exec as a wrapper of byobu-launch or a problem of byobu?

Kosuke Asami (coume) wrote :
Dustin Kirkland  (kirkland) wrote :

Hi there,

Okay, so I think you're actually hitting two bugs, both of which I've recently fixed!

First, the fix to Bug #1264978 helps ensure that the prefix is set correctly, which is especially problematic in MacOSX/homebrew.

Second, the fix to Bug #1289157 actually passes those arguments through from byobu-launch to byobu-launcher to byobu.

I'm going to close this bug for now. Please reopen it if you're still having these problems with the newest release, byobu-5.75 (which I will be releasing today).

Changed in byobu:
importance: Undecided → Medium
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers