Make battery indicator work on Android
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
byobu |
Fix Released
|
Wishlist
|
Dustin Kirkland |
Bug Description
Long story short, I'm running byobu in a Debian chroot on an Android system and noticed that the battery status notification doesn't work with the battery information this Android kernel spits out. In particular, /sys/class/
So I fixed it, see attached patch (against trunk). Notable changes include:
* "uevent" is now read more smartly so that spaces don't break everything
* I've preferred POWER_SUPPLY_
* strings from "uevent" are now lowercased to accommodate for differences in that regard
* I added a configuration variable (BATTERY_
I admit that I didn't test the patch on other devices, but it should support a superset of devices and implementations.
Changed in byobu: | |
status: | New → In Progress |
importance: | Undecided → Wishlist |
assignee: | nobody → Dustin Kirkland (kirkland) |
Changed in byobu: | |
status: | Fix Committed → Fix Released |
Hi Felix,
Thanks for the patch!
I did some basic testing here, and it seems that something in your code has changed the logic, and regressed the battery status support on at least my Thinkpad.
I'll take a closer look and see if I can see what exactly has failed.