Maybe byobu-config creates a file named reload-required at the wrong place

Bug #1255484 reported by kealthou on 2013-11-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu
Medium
Dustin Kirkland 

Bug Description

byobu-config creates "reload-required" at $BYOBU_CONFIG_DIR, but no one else handles the file. I think it should be placed at $BYOBU_RUN_DIR, because lib/byobu/reboot_required checks if reload-required exists there and shows a notification to press F5.

That said, toggling the status notifications and changing the escape key are applied without pressing F5, so creating the file might be useless now.

Dustin Kirkland  (kirkland) wrote :

Another excellent catch. reload-required should always be in run-dir, not config-dir. Thanks!

Committed revision 2254.

Changed in byobu:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Dustin Kirkland  (kirkland)
kealthou (kealthou) wrote :

The fix is broken.

$ byobu-config
Traceback (most recent call last):
  File "/usr/local/bin/byobu-config", line 63, in <module>
    RELOAD_FLAG = "%s/reload-required" % (BYOBU_RUN_DIR)
NameError: name 'BYOBU_RUN_DIR' is not defined

Changed in byobu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers