Detect OS X and show appropiate logo

Bug #1094716 reported by SeySayux on 2012-12-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu
Medium
Dustin Kirkland 

Bug Description

Byobu's "logo" status notification does not detect OS X and instead shows a generic logo. Instead, it should display a more appropriate logo.

Detecting OS X can easily be done through uname ("uname -s" should return "Darwin").

For the logo itself I suggest the following:

logo=" \uF8FF "
$MARKUP && printf "$(color w k)%s$(color -)" "$logo" || printf "$logo"

This will display a black Apple logo on a silver background.

I've tried patching in the check for Darwin manually, to no avail.

Changed in byobu:
importance: Undecided → Medium
assignee: nobody → Dustin Kirkland (kirkland)
status: New → In Progress
Dustin Kirkland  (kirkland) wrote :

Committed revision 2000.

Thanks. I tried my best to improve this. I don't have access to a Mac, so it's currently untested. Can you give the next version of Byobu a shot and let me know if this is any better?

Changed in byobu:
status: In Progress → Fix Committed
SeySayux (seysayux) wrote :

Yes, it seems to work now, but I'd personally recommend you'd use \uF8FF, which looks on Mac systems as an actual Apple logo, instead of the glylph you are using at the moment, which is rendered as the command key icon.

Changed in byobu:
status: Fix Committed → In Progress
Changed in byobu:
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
SeySayux (seysayux) wrote :

Okay, seems to work nicely, thanks!

BTW, bash supports escapes in the form of \uXXXX so you can use that instead of actually trying to type a glyph not in your font.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers