Invoice stuck as pro-forma forever

Bug #999756 reported by Janis Elmeris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Committed
Low
OpenERP R&D Addons Team 3

Bug Description

I create a draft invoice (in Accounting -> Customers -> Customer invoices) forgetting to add an invoice line.
I confirm the draft as a pro-forma invoice.

I cannot validate it to Invoice: "No Invoice Lines ! Please create some invoice lines."
I cannot edit it as it is already confirmed: all fields in the edit mode are grey.
I cannot delete it: "Invalid action ! You can not delete an invoice which is open or paid. We suggest you to refund it instead."

A similar case I have in case of two companies. I get this error: "ValidateError Error occurred while validating the field(s) company_id: Company must be the same for its related account and period."
And I cannot edit anything in the invoice to fix this (whatever it is - I haven't got it, yet).

The OpenERP version is 6.1.

Related branches

Amit Parik (amit-parik)
affects: openobject-server → openobject-addons
Changed in openobject-addons:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
Amit Parik (amit-parik)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Janis,

You have posted this bug report for two different issue.

1st is for proforma invoice and 2nd is on multi-company behaviour you have faced the following error.

"ValidateError Error occurred while validating the field(s) company_id: Company must be the same for its related account and period."

let's first talking about your second point which is invalid because it's not a bug but it's behaviour.You can not validate the other company 's invoice (means your invoice belong to different company then your user). For that you have to use "User Preference" wizard and change the company according to you invoice. For more info and video would you please check lp: 996453, Surely which will help you.

Now comes upon your 2nd issue, As you said after the proforma invoice you can not validate it edit it. The final solution is you have to cancel the invoice, Set invoice at draft state then you can edit it and validate (But I don't think it's good process).

So As per my "Opinion" we have to check the invoice line at the time of the proforma same as a validate time. If there is not invoice line then we can not allow to proforma. For that I have provided a one use case here.

Use-Case: We have use a proforma state for holding of our invoice . After the proforma state we can print our invoice and sent this invoice to customer for the validation (Which is the real scenario). In generalise way first we have proforma invoice, print the invoice send the invoice to customer for the approval for validation. If customer gives a approval then we have to validate it.
At this time assume that we don't have a invoice line and we have sent it to customer, So it doesn't make sense ;-).

So as per the my "Opinion" we have to check invoice line at the time of proforma.
Which will also solved your 1st issue and reduce the more useless steps as I said(Set invoice at draft state then you can edit it and validate ).

I will provide a brach for it :)

Thanks for the understanding!

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Jains,

Your issue#1, has been committed on lp:~openerp-dev/openobject-addons/trunk-bug-999756-amp branch with
rev no : 6795 and rev ID : <email address hidden>

It will merge with trunk soon!

Thanks for the reporting!

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Amit Parik (amit-parik) wrote :

For issue#2 please look at lp:996453

Thanks!

Revision history for this message
Janis Elmeris (janis-elmeris) wrote :

Thank you for the explanation and fast solution!

Only I didn't understand about cancelling the "pro-forma" invoice and setting it to a "draft" state. Is it something I can do already now? I don't see a "Cancel" command for the "pro-forma" invoice.

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Janis,

Yes, you can do it now, If you done your"pro-forma" invoice without invoice line. So you can cancel the invoice , Set to draft state then you can edit the invoice.

I have attached the video which you makes you more clear.

Thank you!

Revision history for this message
Amit Parik (amit-parik) wrote :
Revision history for this message
Janis Elmeris (janis-elmeris) wrote :

Thanks for the video!

I don't have the Cancel button neither in the view nor edit mode. See my attachments.

Should I maybe install another module to get the "Cancel" button?

Revision history for this message
Janis Elmeris (janis-elmeris) wrote :
affects: openobject-addons → openerpwebkitreport
Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Janis,

For cancel button you must have to install account_cancel module and check the "Allow cancel entry " check-box on journal.

Hope this help.

Thanks!

Revision history for this message
Janis Elmeris (janis-elmeris) wrote :

Yes, thank you, that is exactly what I needed.

Amit Parik (amit-parik)
affects: openerpwebkitreport → openobject-addons
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.