Latest update (0.14.1-1ubuntu1.1) broke execution of external commands (including sounds)

Bug #999629 reported by Alexey Zhukov
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gajim (Ubuntu)
Fix Released
Undecided
Unassigned
Lucid
Fix Released
Undecided
Unassigned
Natty
Fix Released
Undecided
Unassigned
Oneiric
Fix Released
Undecided
Unassigned

Bug Description

With last update in Oneiric (0.14.1-1ubuntu1.1), Gajim fails to execute external commands. This blocks sending messages, because when sending a message and Gajim wants to play a sound and calls `aplay`. Then, an error dialog pops up and due to exception, while message is technically sent, it does not appear in chat log, nor disappear from the text entry.

Bug happens on line 387 of src/common/helpers.py, in call `gajim.thread_interface(p.wait)`. ThreadInterface requires 4 parameters, but receives only 1 (excluding implicit `self`).

This is probably because a patch to `exec_command` was backported, but not tested. In more recent versions, ThreadInterface.__init__ declaration differs, allowing to omit arguments, but in 0.14.1 it did not allow so.

A patch in Fedora: http://web.archiveorange.com/archive/v/NUQmug8BKZw9RV60YFtv

Alexey Zhukov (drdaeman)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gajim (Ubuntu Lucid):
status: New → Confirmed
Changed in gajim (Ubuntu Natty):
status: New → Confirmed
Changed in gajim (Ubuntu Oneiric):
status: New → Confirmed
Changed in gajim (Ubuntu):
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gajim - 0.14.1-1ubuntu1.2

---------------
gajim (0.14.1-1ubuntu1.2) oneiric-security; urgency=low

  * update debian/patches/CVE-2012-2085.dpatch:
    fixes regression from 0.14.1-1ubuntu1.1: (LP: #999629)
    execution of external commands broke by missing backport of
    ThreadInterface
 -- Julian Taylor <email address hidden> Tue, 15 May 2012 18:17:05 +0200

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gajim - 0.13.4-3ubuntu2.2

---------------
gajim (0.13.4-3ubuntu2.2) natty-security; urgency=low

  * update debian/patches/CVE-2012-2085.dpatch:
    fixes regression from 0.13.4-3ubuntu2.1: (LP: #999629)
    execution of external commands broke by missing backport of
    ThreadInterface
 -- Julian Taylor <email address hidden> Tue, 15 May 2012 18:17:05 +0200

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gajim - 0.13-0ubuntu2.2

---------------
gajim (0.13-0ubuntu2.2) lucid-security; urgency=low

  * update debian/patches/CVE-2012-2085.dpatch:
    fixes regression from 0.13-0ubuntu2.1: (LP: #999629)
    execution of external commands broke by missing backport of
    ThreadInterface
 -- Julian Taylor <email address hidden> Tue, 15 May 2012 18:17:05 +0200

Changed in gajim (Ubuntu Lucid):
status: Confirmed → Fix Released
Changed in gajim (Ubuntu Natty):
status: Confirmed → Fix Released
Changed in gajim (Ubuntu Oneiric):
status: Confirmed → Fix Released
Changed in gajim (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.