Feedback emails don't retain any comment formatting
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Developer registration portal |
Fix Released
|
Low
|
Michael Nelson |
Bug Description
I just did some reviews for the first time today in my role as an "ARB helper." One thing I noticed is that the emails that get generated don't retain any of the comment's formatting. It's all run together into one big paragraph. Obviously, you can't do detailed code review through this interface, but right now you can't even do something simple like:
----
You need to add ${misc:Depends} to your dependencies. So that line 12 looks like:
Depends: ${shlibs:Depends}, ${misc:Depends}, libgtk-3-0
Here's some more comments.
----
The email would produce something looking like:
You need to add ${misc:Depends} to your dependencies. So that line 12 looks like: Depends: ${shlibs:Depends}, ${misc:Depends}, libgtk-3-0 Here's some more comments.
It would be nice to make this email as easy to read as possible, especially considering bug #925449.
Changed in developer-portal: | |
status: | New → Confirmed |
importance: | Undecided → Low |
Changed in developer-portal: | |
status: | Confirmed → Fix Committed |
assignee: | nobody → Michael Nelson (michael.nelson) |
Changed in developer-portal: | |
milestone: | none → 12.08.2 |
Changed in developer-portal: | |
status: | Fix Committed → Fix Released |
I'm using gmail as a client, and none of the templates css styles are being applied, afaics (see attached).
To at least fix the formatting, can we switch from <p class="pre"> to <pre> for the comments? I'm attaching a branch which does that.