Replay name should contain Widelands version

Bug #998544 reported by Gabriel Margiani
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Wishlist
Unassigned

Bug Description

If you use different versions of Widelands on the same computer or if you have downloaded replays, it would be useful if the name of the replays would contain the version of Widelands which created the replay since replays are incompatible with other versions.

~/.widelands/replays/2012-05-12T21:22:20 build17 singleplayer.wrpl or
~/.widelands/replays/2012-05-12T21:22:20 bzr9999 network player 3 (host).wrpl
instead of
~/.widelands/replays/2012-05-12T21:22:20 singleplayer.wrpl or
~/.widelands/replays/2012-05-12T21:22:20 network player 3 (host).wrpl

I think the build type doesn't matter for compatibility.

Tags: replay

Related branches

Revision history for this message
wl-zocker (wl-zocker) wrote :

I agree. Showing the version would be great. Maybe even more information can be added, as it is presented in bug 846409 (for savegames). Storing the version in the name has the problem that if renamed, the informaitonis lost.

Changed in widelands:
status: New → Confirmed
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

As wl-zocker points out, this information is lost if the replay is renamed as I reckon will be the case with most replays downloaded from somewhere. If possible, I think it is a better idea to show which version the replay was made with in the "load replay" user interface, in addition to map name and length which is already present. From what I understand, save games include the version number in some way, but I am not sure whether replays store this as well.

tags: added: replay
Revision history for this message
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Confirmed → Incomplete
Revision history for this message
wl-zocker (wl-zocker) wrote :

This would be a useful feature - e.g. when I upload a replay to a bug report and forget to mention the version ;)
I would like to add a link to the bug 590528 where the addition of information to replays has been discussed. Although mentioned, the revision number has not been added.

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Thanks for your link and comment.

I see you have commented on some of the bug reports which are sweeped lately. Feel free to set them back to confirmed too. :)

Changed in widelands:
status: Incomplete → Confirmed
Revision history for this message
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Confirmed → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for widelands because there has been no activity for 60 days.]

Changed in widelands:
status: Incomplete → Expired
SirVer (sirver)
Changed in widelands:
status: Expired → Confirmed
GunChleoc (gunchleoc)
Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
status: Confirmed → In Progress
milestone: none → build19-rc1
Revision history for this message
TiborB (tiborb95) wrote :

This is for code that GunChleoc is working for - more info https://code.launchpad.net/~widelands-dev/widelands/bug-998544/+merge/251947

Revision history for this message
GunChleoc (gunchleoc) wrote :

I can't reproduce this - seems like I don't have a replay that has the same version of the preload packet. Could you attach your replay file please?

Revision history for this message
TiborB (tiborb95) wrote :

I downloaded this: http://www.widelands.org/~hanna/wl/tournament2015/Replays/Group2Tulips%28blue%2cred%29vsTeamA%28yellow%2cgreen%29_r7425.zip

What is strange, if there was another replay -everything was fine, if only this one was shown (as on screenshot) the text overlaps. So empty the replay folder first, please...

Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks! I can reproduce this now - it happens whenever the first replay on the list is incompatible.

GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
GunChleoc (gunchleoc)
Changed in widelands:
assignee: GunChleoc (gunchleoc) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.