[feisty] stop hotkey not working

[Nicolò Chieffo]

Binary package hint: banshee

I know that the gnome policy is to make users to forget the existance of the possibility to stop a song.
They now can only pause a song. This is ok for me.

Please implement this handler for the stop hotkey!
Now when I hit my stop hotkey nothing happens...

[Nicolò Chieffo (yelo3)]

protected override void PluginInitialize()
{
    special_keys = new SpecialKeys();
    special_keys.Delay = new TimeSpan(500 * TimeSpan.TicksPerMillisecond);

    special_keys.RegisterHandler(OnSpecialKeysPressed,
    SpecialKey.AudioPlay,
    SpecialKey.AudioPrev,
    SpecialKey.AudioNext
    );
}

as we can see the stop hotkey is even not considered...
please add it!

[Cesare Tirabassi (norsetto)]

Just for my personal culture.
Would adding SpecialKey.AudioStop to the list in MMKeysPlugin.cs make it work?
If so, why not proposing a patch upstream? Perhaps it is faster :)
Beside your joke, is there any reason you know why this MM key is disabled by default in gnomeconf?

Thanks.

[Nicolò Chieffo (yelo3)]

I just know that every gnome app starts without this key considered.
rhythmbox upstream told me that they don't want to have the stop
feature, so they decided to map pause to the stop hotkey

[Chris Halse Rogers (raof)]

Here's a (currently untested) debdiff to fix this. Please test it out, see if it fixes it for you.

I'll test it out this evening.

[Nicolò Chieffo (yelo3)]

can you upload it upstream?

[Wouter Stomp (wouterstomp-deactivatedaccount)]

This was fixed upstream and should be in ubuntu now.