Invalid --max-load and --critical-load crash pt-online-schema-change
Bug #996915 reported by
Will Gunty
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Daniel Nichter | ||
2.0 |
Fix Released
|
Medium
|
Daniel Nichter | ||
2.1 |
Fix Released
|
Medium
|
Daniel Nichter |
Bug Description
If --max-load and/or --critical-load are not in the correct format, the tool "crashes" without a good error message:
wgunty@dba1001:~$ pt-online-
Use of uninitialized value in multiplication (*) at /usr/bin/
Expected behavior should error and state that an invalid format has been entered.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/validate-load-options-bug-996915
- Daniel Nichter: Approve
-
Diff: 612 lines (+315/-89)6 files modifiedbin/pt-online-schema-change (+91/-31)
bin/pt-table-checksum (+88/-30)
lib/MySQLStatusWaiter.pm (+60/-24)
t/lib/MySQLStatusWaiter.t (+49/-2)
t/pt-online-schema-change/option_sanity.t (+15/-1)
t/pt-table-checksum/option_sanity.t (+12/-1)
lp:~percona-toolkit-dev/percona-toolkit/validate-load-options-bug-996915-2.0
- Daniel Nichter: Approve
-
Diff: 559 lines (+291/-61)4 files modifiedbin/pt-table-checksum (+111/-31)
lib/MySQLStatusWaiter.pm (+82/-24)
t/lib/MySQLStatusWaiter.t (+86/-5)
t/pt-table-checksum/option_sanity.t (+12/-1)
tags: | added: crash option-parsing |
Changed in percona-toolkit: | |
status: | New → Triaged |
summary: |
- pt-online-schema-change Crash when --max-load and --critical-load are - not valid + Invalid --max-load and --critical-load crash pt-online-schema-change |
To post a comment you must log in.
See also bug 972026.