Mixxx

No end-of-track warning on tracks <30s long

Bug #996464 reported by Sean M. Pappalardo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Thomas Vincent
Mixxx 1.11.0

Bug Description

Disable the end-of-track warning for tracks that are 30s or less long, since it's active the entire time.

Related branches

lp:~vrince/mixxx/waveform-2.0_pure-gl
RJ Skerry-Ryan: Pending requested
Diff: 3454 lines (+1509/-1139)
39 files modified
mixxx/build/depends.py (+12/-3)
mixxx/res/skins/Deere1280x800-WXGA/skin.xml (+10/-448)
mixxx/src/engine/cuecontrol.cpp (+0/-2)
mixxx/src/engine/cuecontrol.h (+2/-0)
mixxx/src/skin/legacyskinparser.cpp (+2/-3)
mixxx/src/waveform/renderers/glslwaveformrenderersignal.cpp (+21/-7)
mixxx/src/waveform/renderers/glslwaveformrenderersignal.h (+4/-8)
mixxx/src/waveform/renderers/glwaveformrendererfilteredsignal.cpp (+177/-324)
mixxx/src/waveform/renderers/glwaveformrendererfilteredsignal.h (+4/-34)
mixxx/src/waveform/renderers/glwaveformrenderersimplesignal.cpp (+120/-185)
mixxx/src/waveform/renderers/glwaveformrenderersimplesignal.h (+4/-21)
mixxx/src/waveform/renderers/qtwaveformrendererfilteredsignal.cpp (+346/-0)
mixxx/src/waveform/renderers/qtwaveformrendererfilteredsignal.h (+36/-0)
mixxx/src/waveform/renderers/qtwaveformrenderersimplesignal.cpp (+223/-0)
mixxx/src/waveform/renderers/qtwaveformrenderersimplesignal.h (+31/-0)
mixxx/src/waveform/renderers/waveformmark.cpp (+0/-4)
mixxx/src/waveform/renderers/waveformrendererendoftrack.cpp (+4/-0)
mixxx/src/waveform/renderers/waveformrendererfilteredsignal.cpp (+107/-34)
mixxx/src/waveform/renderers/waveformrendererfilteredsignal.h (+7/-12)
mixxx/src/waveform/renderers/waveformrenderersignalbase.cpp (+83/-0)
mixxx/src/waveform/renderers/waveformrenderersignalbase.h (+38/-0)
mixxx/src/waveform/renderers/waveformrendermark.cpp (+43/-5)
mixxx/src/waveform/renderers/waveformrendermark.h (+1/-0)
mixxx/src/waveform/renderers/waveformwidgetrenderer.cpp (+9/-3)
mixxx/src/waveform/renderers/waveformwidgetrenderer.h (+1/-1)
mixxx/src/waveform/waveformwidgetfactory.cpp (+31/-23)
mixxx/src/waveform/widgets/glsimplewaveformwidget.cpp (+2/-6)
mixxx/src/waveform/widgets/glsimplewaveformwidget.h (+0/-3)
mixxx/src/waveform/widgets/glslwaveformwidget.cpp (+4/-4)
mixxx/src/waveform/widgets/glslwaveformwidget.h (+1/-1)
mixxx/src/waveform/widgets/glwaveformwidget.cpp (+3/-2)
mixxx/src/waveform/widgets/qtsimplewaveformwidget.cpp (+57/-0)
mixxx/src/waveform/widgets/qtsimplewaveformwidget.h (+30/-0)
mixxx/src/waveform/widgets/qtwaveformwidget.cpp (+56/-0)
mixxx/src/waveform/widgets/qtwaveformwidget.h (+30/-0)
mixxx/src/waveform/widgets/softwarewaveformwidget.cpp (+3/-2)
mixxx/src/waveform/widgets/softwarewaveformwidget.h (+1/-1)
mixxx/src/waveform/widgets/waveformwidgettype.h (+3/-1)
mixxx/src/widget/wwaveformviewer.cpp (+3/-2)
Sean M. Pappalardo (pegasus-renegadetech)
description: updated
Revision history for this message
Thomas Vincent (vrince) wrote :

For the flashing part I can add on/off time in skin so that skin designer can make it "flash" instead of fade. Will it do ?
For the less that 30 sec, it's a go.

Changed in mixxx:
assignee: nobody → Thomas Vincent (vrince)
Revision history for this message
jus (jus) wrote :

Imo the end of track warning time should be user configurable in the preferences, not hiding deep within the skin.xml. It might save us from future support requests ( "...oh this is so annoying. how to make it stop..") . Having then explain to the user he needs to dig inside xml files ? No.
We might need an extra waveform tab in the preferences with all the option:)

Revision history for this message
Thomas Vincent (vrince) wrote :

Yeah let's do that.
I like the "... this is so annoying ... " stuff :) ... mixxxers ...

Revision history for this message
RJ Skerry-Ryan (rryan) wrote : Re: [Bug 996464] Re: No end-of-track warning on tracks <30s long

I like the fading versus flashing and I think that making an option for
flashing should be bottom-of-the-barrel-low-priority. There are much bigger
things to work on for 1.11.0 :). We should leave it as an open bug report
and mark it as an easy/wishlist.

On Fri, May 11, 2012 at 9:58 AM, Thomas Vincent
<email address hidden>wrote:

> Yeah let's do that.
> I like the "... this is so annoying ... " stuff :) ... mixxxers ...
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/996464
>
> Title:
> No end-of-track warning on tracks <30s long
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/996464/+subscriptions
>

Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

I made the mistake of combining two bugs in one report again. I'm declaring this one just for the no-warning-on-short-tracks which Thomas said he's working on presumably in his branch, so marking In Progress until his branch is merged. I'll file another for the flashing.

Changed in mixxx:
milestone: none → 1.11.0
status: Confirmed → In Progress
description: updated
Thomas Vincent (vrince)
Changed in mixxx:
status: In Progress → Fix Committed
Thomas Vincent (vrince)
Changed in mixxx:
importance: Wishlist → Low
Thomas Vincent (vrince)
Changed in mixxx:
status: Fix Committed → In Progress
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6411

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.