Search filter is not deleted on emtpy search string if tag_pane is closed

[Stefan Handschuh]

Version 0.2.9-1 from debian testing (date: 2012-02-13)

In the above stated version of gtg, I could not remove the search filter without using the "Tags sidebar" (tag_pane) , once a search has been perfomed in the quickadd_entry.

A simple patch (that is only supposed to show the idea) against 0.2.9 is attached to this report that affects the on_quickadd_changed method of GTG/gtk/browser/browser.py

However, I assume this behavior is intentional but in case of the tag_pane being not visible, I find this somehow irritating.

[Izidor Matušov (izidor)]

Thanks for the patch. All developers use GTG with the visible tag_page and some strange behavior we don't find ourselves. Your patch looks good and simple. In my opinion, it is too extreme to remove all search tags (somebody might write a complicated query and doesn't want to loose it). Would it be okay with you to delete only the current search filter or just un-apply the search filter?

(I can update the patch)

[Stefan Handschuh (handschuh)]

Thank you for your fast response.

Of course, feel free to change the patch in whatever way you like.