PO activation fails to process already-queued records

Bug #993322 reported by Bill Erickson
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.3
Fix Released
Undecided
Unassigned

Bug Description

If an ACQ lineitem is uploaded and queued (but not imported as a catalog record) via the vendor upload UI, future attempts to activate a PO with the lineitem will either fail (if no queue is re-specified) or (unverified) create extra vandelay records, some of which are effectively orphaned.

The linked branch repairs this problem by inspecting lineitems as they are processed to determine whether they need to be linked to a queued record. It also removes the requirement that a queue be specified when all records in process are already linked to vandelay records.

To test, upload some MARC records in the ACQ vendor upload UI. When doing so, add them to a queue, but do not choose any of the import/merge/overlay options. Create a PO from the record, give it copies, price, etc. Attempt to activate the PO choosing "import non-matching records" and nothing else. With the patch, the import should succeed.

working => collab/berick/acq-support-two-step-vandelay-import

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/berick/acq-support-two-step-vandelay-import

Tags: pullrequest
Changed in evergreen:
milestone: 2.2.0rc1 → 2.2.0
Changed in evergreen:
milestone: 2.2.0 → 2.2.1
Revision history for this message
Kathy Lussier (klussier) wrote :
Changed in evergreen:
milestone: 2.2.1 → 2.2.2
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.2.2 → 2.2.3
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Pushed with Kathy's signoff from master back through rel_2_2. Thanks all!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.