monitor tests need to accept video output identifiers used by proprietary drivers
Bug #992727 reported by
Brendan Donegan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
High
|
Sylvain Pineau |
Bug Description
The monitor tests currently use a requires field like:
requires: display.hdmi == 'supported'
to see if a particular test should run on a particular system. It seems that some of the proprietary drivers use some eccentric names for these video ports. For example on one ATI system the fglrx driver called the VGA port 'CRT1' and the HDMI port 'DFP1'. The requires field for those tests should include those identifiers, like:
requires: display.hdmi == 'supported' or display.dfp == 'supported'
Related branches
lp:~sylvain-pineau/checkbox/display_resource
- Brendan Donegan (community): Approve
- Sylvain Pineau (community): Needs Resubmitting
-
Diff: 116 lines (+89/-1)3 files modifieddebian/changelog (+3/-0)
jobs/resource.txt.in (+2/-1)
scripts/display_resource (+84/-0)
lp:~roadmr/ubuntu/quantal/checkbox/0.14.8
- Daniel Holbach (community): Approve
- Micah Gersten (community): Needs Fixing
- Ubuntu branches: Pending requested
-
Diff: 4032 lines (+691/-1663)52 files modifiedbackend (+7/-3)
checkbox/parsers/udevadm.py (+8/-1)
data/whitelists/default.whitelist (+1/-0)
debian/changelog (+56/-0)
debian/control (+7/-2)
debian/po/ast.po (+2/-2)
debian/po/cs.po (+2/-2)
debian/po/de.po (+2/-2)
debian/po/en_AU.po (+2/-2)
debian/po/en_GB.po (+2/-2)
debian/po/es.po (+4/-3)
debian/po/fr.po (+13/-13)
debian/po/he.po (+2/-2)
debian/po/hu.po (+2/-2)
debian/po/id.po (+2/-2)
debian/po/it.po (+2/-2)
debian/po/ja.po (+2/-2)
debian/po/nl.po (+2/-2)
debian/po/oc.po (+2/-2)
debian/po/pl.po (+2/-2)
debian/po/pt_BR.po (+2/-2)
debian/po/ro.po (+2/-2)
debian/po/ru.po (+2/-2)
debian/po/tr.po (+2/-2)
debian/po/uk.po (+2/-2)
debian/po/zh_CN.po (+2/-2)
debian/po/zh_TW.po (+2/-2)
jobs/cpu.txt.in (+1/-0)
jobs/esata.txt.in (+0/-6)
jobs/firewire.txt.in (+0/-6)
jobs/mediacard.txt.in (+0/-48)
jobs/optical.txt.in (+90/-52)
jobs/resource.txt.in (+1/-1)
jobs/usb.txt.in (+7/-19)
jobs/wireless.txt.in (+17/-3)
plugins/apport_prompt.py (+0/-280)
plugins/backend_info.py (+60/-21)
plugins/suites_prompt.py (+8/-1)
po/POTFILES.in (+0/-1)
po/ar.po (+13/-12)
po/fi.po (+28/-14)
po/fr.po (+131/-109)
po/pt_BR.po (+5/-5)
qt/checkbox-qt.ui (+0/-935)
qt/frontend/qtfront.cpp (+2/-1)
qt/frontend/qtfront.ui (+8/-5)
scripts/display_resource (+84/-0)
scripts/graphics_driver (+81/-50)
scripts/network_info (+15/-2)
scripts/network_wireless_test (+0/-25)
scripts/optical_write_test (+3/-4)
setup.py (+1/-1)
Changed in checkbox: | |
assignee: | nobody → Sylvain Pineau (sylvain-pineau) |
status: | Triaged → In Progress |
Changed in checkbox: | |
status: | In Progress → Fix Committed |
Changed in checkbox: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The test dependencies shouldn't need to deal with proprietary driver wonkiness. The display resource should instead map all possible identifiers to a single, agreed-upon name (and really, whose braindead idea was it that you can only plug a CRT to the 15-ping VGA connector? what does DFP1 stand for?) I'd say mapping them to industry-standard names like, oh I don't know, VGA or HDMI or displayport (I do see maybe thunderbolt appearing in the future) and keeping that concern out of the test definitions may be good.