Filezilla crashes when connecting to remote site

[jessesmith]

I am running Kubuntu 12.04 64-bit.

Problem:
When I try to use Filezilla to connect to any remote server using the Filezilla site manager, Filezilla crashes with the error:

The program 'filezilla' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadWindow (invalid Window parameter)'.
  (Details: serial 29595 error_code 3 request_code 152 minor_code 3)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

This error occurres every time I try to connect to a remote site using the Filezilla site manager. However, if I try to connect to a remote site by manually entering my login data on the Quick connect toolbar, Filezilla completes the connection without any problems.

I have tested this against FTP and SFTP sites and found both will trigger the crash when using the site manager, but not when using Quick Connect. I have also tried installing multiple versions of Filezilla (3.4, 3.5.1, 3.5.3) and found the problem persists. This leads me to believe the bug may be with X as much as with Filezilla itself.

Steps to reproduce:
1. open Filezilla
2. Open the site manager.
3. Select any remote site.
4. click "Connect"
5. Filezilla crashes

Steps to work around
1. open Filezilla
2. Enter connection data in the fields along the top of the application
3. Click "quick connect" button
4. Filezilla connects without crashing

I have tried removing my Filezilla configuration files and making new site manager entries from scratch. The problem continues even with the fresh configuration.

[Federico Stafforini (fstafforini)]

Running wingide 4.1.3 with oxygen-gtk2theme selected will crash every time certain dialogs are closed (for instance start/continue or project properties).

This happens since 1.2.2 and onwards, also with today's git version. It does not happen in oxygen-gtk2 1.2.0.

No other theme causes this, the program works fine under all other gtk themes.
This happens with wingide professional 4.1.3. So far I haven't found any other dialog in another app where this happens (but I don't use many gtk2 apps).

Console output:
    The program wing.py received an X Window System error.
    This probably reflects a bug in the program.
    The error was BadWindow (invalid Window parameter).
      (Details: serial 31563 error_code 3 request_code 152 minor_code 3)
      (Note to programmers: normally, X errors are reported asynchronously;
       that is, you will receive the error a while after causing it.
       To debug your program, run it with the --sync command line
       option to change this behavior. You can then get a meaningful
       backtrace from your debugger if you break on the gdk_x_error() function.)

[Federico Stafforini (fstafforini)]

This happens under x86-64 architecture. Could not reproduce bug using 32 bit libs and apps on the same system.

[Ruslan (b7-10110111)]

Please use git-bisect to find the guilty commit.

[Hugo Pereira Da Costa (hugo-pereira)]

*** Bug 295966 has been marked as a duplicate of this bug. ***

[Hugo Pereira Da Costa (hugo-pereira)]

@Ruslan, others
I suspect fe399f97bd478a33241a5a4213498072292ce841
To be the guilty guy. (basically reverting compositing on a window that has been already destroyed).
Can someone that experience the bug
1/ get oxygen gtk from source
   git clone git://anongit.kde.org/oxygen-gtk
2/ checkout before the commit before
   git checkout fe399f97bd478a33241a5a4213498072292ce841^
(don't forget the "^")
3/ compile and see if the bug is still there
4/ checkout the revision: git checkout fe399f97bd478a33241a5a4213498072292ce841
5/ compile and see if the bug is here.

[Hugo Pereira Da Costa (hugo-pereira)]

@Ruslan
Note: if this indeed is the bug, the fix (that does not break gtk-chtheme) would be either
- find a way to check the validity of the window before reverting compositing (might be difficult)
- not reverting compositing in destructor (disconnect)
- revert everything manually in theme exit (for lxappearance or gth-chtheme)
I sure can work on that but need confirmation first.

[Ruslan (b7-10110111)]

(In reply to comment #5)
If you mean that the problem is our gdk_window_set_composited(window,_initiallyComposited), then it's strange that we get BadWindow after GDK_IS_WINDOW returns true.
Also, I'd rather see which request fails using --sync option to GTK program and breaking on gdk_x_error().

[Hugo Pereira Da Costa (hugo-pereira)]

@ruslan,
might be an underlying gtk issue
GdkWindow still exists, but underlying X window is gone (unmapped or smthing like that)
then crash when gdk_window_set_composite (or whatever the name) try access the X window to change the "composite" flag ... something like that.
(iirc, I've seen this happen for other calls)

[Ruslan (b7-10110111)]

(In reply to comment #7)
It seems you might be right. There's a gdk_window_is_destroyed() function, so maybe we should check it before setting composite state.

[Ruslan (b7-10110111)]

Git commit d6c4de90902a005fc14e55c1789bec276dbfcdf0 by Ruslan Kabatsayev.
Committed on 14/03/2012 at 12:04.
Pushed by kabatsayev into branch '1.2'.

Check if GdkWindow is destroyed before restoring composited state

M +1 -1 src/animations/oxygeninnershadowdata.cpp

http://commits.kde.org/oxygen-gtk/d6c4de90902a005fc14e55c1789bec276dbfcdf0

[Hugo Pereira Da Costa (hugo-pereira)]

@ruslan
sounds good.
Although I'd like to have confirmation for comment #4
Anyone ?

Thanks for the commit anyway ! (can't hurt)

[Hugo Pereira Da Costa (hugo-pereira)]

@Ruslan,
good news,
without your commit (forward ported to gtk3), gtk3-demo was crashing at exit (likely with the same issue), and is not anymore. Most likely your fix works !

[Ruslan (b7-10110111)]

OK, I mark this fixed. If it appears to not be, please reopen.

[Federico Stafforini (fstafforini)]

I confirm the original issue is fixed. Thanks!

[Ruslan (b7-10110111)]

*** Bug 296082 has been marked as a duplicate of this bug. ***

[jessesmith (jessefrgsmith)]

Further experimenting has shown the bug can be triggered by opening the site manager and selecting any of the buttons which will cause the site manager dialog to close. For example

1. Open Filezilla
2. Click the "site manager" button.
3. Click the "cancel" button when site manager appears.

This issue appears to be a duplicate of this one, which was later linked to an issue with X11:
http://trac.filezilla-project.org/ticket/3381
https://rhn.redhat.com/errata/RHSA-2008-0031.html

[Julio Cardoso (julio-linuxgroups)]

i have same problem
Kubuntu i386
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 12.04 LTS
Release: 12.04
Codename: precise

the problem is in oxygen-gtk widget when you switch to another theme it works normally

when you connect it to a site of this error

xjulio@xjulio-PC:~$ filezilla
The program 'filezilla' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadWindow (invalid Window parameter)'.
  (Details: serial 62278 error_code 3 request_code 155 minor_code 3)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

[jessesmith (jessefrgsmith)]

I have confirmed that going into the KDE System Settings -> Application Appearance -> GTK+ Appearance and changing the widget style to something other than "oxygen-gtk" prevents Filezilla from crashing. The work around has the side effect of making GTK apps look boxy, but it does fix the crash. (Thanks Julio!)

Another work around, if we know the name of the site (as it appears in the Filezilla site manager) we want to connect to is to launch Filezilla from the command line. Running

filezilla -c 0/host-nickname/ &

will also work around the crash with site manager.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gtk2-engines-oxygen - 1.2.3-0ubuntu1

---------------
gtk2-engines-oxygen (1.2.3-0ubuntu1) quantal; urgency=low

  * New upstream release.
    - Fixes crash in Filezilla. (LP: #992133)
 -- Felix Geyer <email address hidden> Sun, 06 May 2012 11:57:43 +0200

[Martin Pitt (pitti)]

Hello jessesmith, or anyone else affected,

Accepted gtk2-engines-oxygen into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[jessesmith (jessefrgsmith)]

Confirmed, the fix works. Upgrading to the gtk2-engines-oxygen-0ubuntu1.1 package in the precise-proposed repository fixes the Filezilla crash. I think we can consider this bug resolved. Thank you.

[Luc Bruninx (luc2005)]

I confirme that this fix works for my system too.

[Luc Bruninx (luc2005)]

Don't forget to remove proposed updates after you have applyed the fix.

[Jan Owoc (jsowoc)]

I was experiencing crashing of FileZilla with the oxygen-gtk theme in Kubuntu 12.04. Bug #987410 outlined a few temporary workarounds.

Updating gtk2-engines-oxygen from precise-proposed fixed the problem permanently, and I can revert to using the oxygen-gtk theme. I have no problems with the update.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gtk2-engines-oxygen - 1.2.2-0ubuntu1.1

---------------
gtk2-engines-oxygen (1.2.2-0ubuntu1.1) precise-proposed; urgency=low

  * Fix crash in Filezilla when connecting to a remote site. (LP: #992133)
    - Add fix-filezilla-crash.patch, cerry-picked from upstream.
 -- Felix Geyer <email address hidden> Sun, 06 May 2012 11:47:50 +0200

[Ron (ron-f1)]

fixed with gtk2-engines-oxygen - 1.2.2-0ubuntu1.1, many thanks