Allow subscriptions at org units without volumes

Bug #988519 reported by Dan Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Status tracked in Main
2.0
Fix Released
Undecided
Unassigned
2.1
Fix Released
Undecided
Unassigned
2.2
Fix Released
Undecided
Unassigned
Main
Fix Released
High
Unassigned

Bug Description

Subscriptions are sometimes owned at the consortium or system level, so forcing can_have_vols() to be true was incorrect.

This commit removes those checks in the Serial Control interface.

branch:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/allow_subs_without_vols

Tags: pullrequest
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Dan Wells and I worked on this together to take it further. As I recall, we decided something was still missing, so I'm removing the pullrequest tag for now.

Dan, if this was in fact ready to go, let me know at your earliest convenience and it can get final testing and merging.

Thanks!

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/senator/allow_subs_without_vols

tags: removed: pullrequest
Revision history for this message
Dan Wells (dbw2) wrote :

Yes, it didn't throw any errors, but it was a little quirky in a few cases. I have corrected the quirks I could find, squashed and rebased, and removed a well-rounded spoonful of dead code while I was at it (hmmm, guess I won't be using that spoon anymore).

Force-pushed branch is here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/allow_subs_without_vols

In my testing, this also picks cleanly into rel_2_1 and rel_2_0, so I see no reason to not backport it.

Thanks!
Dan

tags: added: pullrequest
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Works in my testing. Thanks again Dan. Signed off and pushed back through rel_2_0

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.