codebrowse urls are long and confusing

Bug #98826 reported by Michael Hudson-Doyle
6
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Unassigned
loggerhead
Fix Released
Medium
Robey Pointer

Bug Description

I'd like to work on letting pydoctor, my API doc generation tool, link to source as presented by codebrowse (it already has support for linking to trac's source viewer). Currently the codebrowse urls contain file-ids, which I could dig out of the wc being generated from, but well, it's not nice :)

spiv said on IRC that he thought allowing "filename=..." as an alternative to "file-id=..." looked easy enough.

Revision history for this message
James Henstridge (jamesh) wrote :

I talked with Robert about this. The two changes we should probably make include:

1. use the filename as part of the URL. Rather than "/annotate/$REVID?file_id=$FILEID", use "/annotate/$REVID/$FILENAME".

2. allow some short hand to refer to the head revision ID. Robert suggested "head:", which would give a URL like "/annotate/head:/$FILENAME".

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I'm not sure point 2) is especially relevant to my use case, as I think pydoctor documentation will be generated from a particular revision, so may as well link to a particular revision... point 1) seems nice, even just from a human interface point of view.

Revision history for this message
Robey Pointer (robey) wrote :

I originally used filename instead of fileid, but I think I had some issues looking up the correct file object from that. I guess if the filename was always pulled from the stated revision, it would work.

Hm, in fact, I just tried patching loggerhead to use James' point #1 above, and it seems to work fine. I'll check it in.

Changed in loggerhead:
assignee: nobody → robey
importance: Undecided → Medium
status: Unconfirmed → Confirmed
Revision history for this message
Robey Pointer (robey) wrote :

rev 126. point #2 was easy to do too.

Changed in loggerhead:
status: Confirmed → Fix Committed
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This is in production too now.

Changed in launchpad-bazaar:
status: Unconfirmed → Fix Released
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Released in 1.2, though we can do better...

Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.