Keypair import should tolerate CR & LF

Bug #988139 reported by justinsb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Tihomir Trifonov

Bug Description

Keypair import shouldn't fail if a CR or LF makes its way into the string, e.g. because you copied and pasted from a shell.

Simply strip them out; they can't be in a key anyway (I think)...

Devin Carlen (devcamcar)
Changed in horizon:
status: New → Confirmed
milestone: none → folsom-1
importance: Undecided → Low
Devin Carlen (devcamcar)
Changed in horizon:
assignee: nobody → Nebula (nebula)
Thierry Carrez (ttx)
Changed in horizon:
milestone: folsom-1 → folsom-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8933

Changed in horizon:
assignee: Nebula (nebula) → Tihomir Trifonov (ttrifonov)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/8933
Committed: http://github.com/openstack/horizon/commit/aa6919d673026fdc667bd7a78d480b004fc2b989
Submitter: Jenkins
Branch: master

commit aa6919d673026fdc667bd7a78d480b004fc2b989
Author: Tihomir Trifonov <email address hidden>
Date: Mon Jun 25 18:59:04 2012 +0300

    Removed new lines when importing a keypair

    Fixes bug 988139

    All new lines (\r, \n) are removed from input
    when importing a keypair. This is done as sometimes
    a user copies the public key from terminal, with
    new lines in it. As new lines are not allowed in
    a public key, so they are stripped.

    Change-Id: If526bf081448e315f3518d7ecd2689ec816b77a7

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.