the GObject subclasses in tests/ don't dispose() properly

Bug #986875 reported by Charles Kerr
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Low
Charles Kerr
unity (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The subclasses in these files override their parents' dispose() method without invoking it:

 * tests/test_service_gdbus_wrapper.c
 * tests/test_service_hud.c
 * tests/test_service_lens.c
 * tests/test_service_model.c

This is a very low priority -- it's test scaffolding and doesn't affect end users (or, apparently, the tests) -- but figured it couldn't hurt to send a patch.

I found this while grepping after seeing a similar issue in the indicator code. :)

Related branches

Tim Penhey (thumper)
Changed in unity:
assignee: nobody → Charles Kerr (charlesk)
status: New → In Progress
milestone: none → 6.0
Changed in unity:
milestone: 6.0 → 6.2
Changed in unity:
milestone: 6.2 → 6.4
Changed in unity:
milestone: 6.4 → 6.6
Changed in unity:
milestone: 6.6 → 7.0
Changed in unity:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 6.12.0daily13.02.04.1-0ubuntu1

---------------
unity (6.12.0daily13.02.04.1-0ubuntu1) raring; urgency=low

  * debian/control:
    - recommends indicator-sync so it gets installed by default
      (lp: #1053482)
    - recommends indicator-bluetooth as well (lp: #1111314)

  [ Łukasz 'sil2100' Zemczak ]
  * debian/control:
    - bump compiz build-dep due to the last ABI break

  [ Brandon Schaefer ]
  * [regression] Clicking on the indicators when the Dash is open no
    longer closes the Dash. (LP: #1109150)
  * [staging][raring] Dash Maximise/Restore button depends on the
    launcher icon size. (LP: #1101310)

  [ Romain Perier ]
  * The Dash closes when trying to switch to the Command lens (Alt+F2)
    (LP: #1019457)

  [ Marco Trevisan (Treviño) ]
  * Launcher can have smaller size on monitor resolution change (LP:
    #1105382)
  * Dragging down a window from the panel on an external monitor,
    restores it at wrong offset (LP: #1104043)
  * [regression] Alt+Tab/Alt+grave brings other window to the front but
    loses focus entirely. (LP: #1111620)
  * Quicklist items need a way to be ellipsized (LP: #1111471)

  [ Charles Kerr <email address hidden>, Andrea Azzarone ]
  * the GObject subclasses in tests/ don't dispose() properly (LP:
    #986875)

  [ Nicolas d'Offay ]
  * Speed up dash blur (LP: #1102410)

  [ Manuel de la Pena ]
  * API changes to FindKeyFocusArea in the Preview class stops more
    complicated previous fom setting the correct focus (LP: #1102387)

  [ MC Return ]
  * Wrong description in Dconf key
    com.canonical.unity.launcher.favorites (LP: #1112560)
  * Keyboard shortcut overlay says Ctrl+Super+Down "minimises" the
    current window, but it doesn't (LP: #966099)

  [ Andrea Azzarone ]
  * unmounting any gvfs-mounted device from unity menu crashes compiz
    (LP: #1111389)
  * compiz crashed with SIGSEGV in async_wrapper_callback() from
    g_simple_async_result_complete() from
    _g_simple_async_result_complete_with_cancellable() from
    unmount_reply() (LP: #1102926)

  [ Łukasz 'sil2100' Zemczak ]
  * SwitcherControllerImpl autopilot test failures in unity -
    6.12.0daily13.01.29.2-0ubuntu1 (LP: #1109192)

  [ Automatic PS uploader ]
  * Automatic snapshot from revision 3117
 -- Automatic PS uploader <email address hidden> Mon, 04 Feb 2013 09:59:13 +0000

Changed in unity (Ubuntu):
status: New → Fix Released
Revision history for this message
Stephen M. Webb (bregma) wrote :

Fix Released in Unity Unity 7.0.0 "R series".

Changed in unity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.