pt-stalk does not report NFS iostat
Bug #986847 reported by
Olivier Doucet
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Brian Fraser | ||
| 2.0 |
Won't Fix
|
Undecided
|
Unassigned | ||
| 2.1 |
Fix Released
|
Medium
|
Brian Fraser | ||
Bug Description
in pt-stalk, iostat is launched with flags 'dx'.
When MySQL datadir is on NFS, iostat usage is not reported because iostat needs flag 'n' to report NFS volumes.
How to fix :
add -n to each call to iostat binary.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/experimental-fix-986847-pt-stalk-set-command
- Daniel Nichter: Approve
-
Diff: 166 lines (+90/-26)3 files modifiedbin/pt-stalk (+55/-13)
lib/bash/collect.sh (+12/-12)
t/lib/bash/collect.sh (+23/-1)
| tags: | added: pt-stalk sys-cmd |
Revision history for this message
| Brian Fraser (fraserbn) wrote | #1 |
Revision history for this message
| Olivier Doucet (odoucet) wrote | #2 |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #3 |
To post a comment you must log in.
The attached branch doesn't exactly fix this, because just adding the -n would've meant a bunch of useless clutter to people not using NFS, but instead lets you work around it by doing something like this:
$ CMD_IOSTAT="iostat -n" pt-stalk ...
Which will make pt-stalk use 'iostat -n -dx ...'. You can actually replace most commands used by pt-stalk with this, so in conjunction with the new --plugin interface, it should let you do most things in whichever way you want.
I think this is the way to go, and will be merging it soon (with docs) unless someone objects / thinks it's a brain-damaged idea / etc.